linux-kernel - Re: [PATCH 03/30] usb: ohci-at91: Use devm_platform_get_and_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bdb58dfb-9423-4949-9b2a-e979bfebb2f4@rowland.harvard.edu>
Date:   Wed, 26 Jul 2023 10:29:28 -0400
From:   Alan Stern <stern@...land.harvard.edu>
To:     Yangtao Li <frank.li@...o.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>,
        linux-usb@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/30] usb: ohci-at91: Use
 devm_platform_get_and_ioremap_resource()

On Wed, Jul 26, 2023 at 10:27:43AM -0400, Alan Stern wrote:
> On Wed, Jul 26, 2023 at 07:37:49PM +0800, Yangtao Li wrote:
> > Convert platform_get_resource(), devm_ioremap_resource() to a single
> > call to devm_platform_get_and_ioremap_resource(), as this is exactly
> > what this function does.
> > 
> > Signed-off-by: Yangtao Li <frank.li@...o.com>
> > ---
> >  drivers/usb/host/ohci-at91.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c
> > index b9ce8d80f20b..f957d008f360 100644
> > --- a/drivers/usb/host/ohci-at91.c
> > +++ b/drivers/usb/host/ohci-at91.c
> > @@ -200,8 +200,7 @@ static int usb_hcd_at91_probe(const struct hc_driver *driver,
> >  		return -ENOMEM;
> >  	ohci_at91 = hcd_to_ohci_at91_priv(hcd);
> >  
> > -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > -	hcd->regs = devm_ioremap_resource(dev, res);
> > +	hcd->regs = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
> >  	if (IS_ERR(hcd->regs)) {
> >  		retval = PTR_ERR(hcd->regs);
> >  		goto err;
> 
> Did you try to test-compile this change (and all the similar ones in 
> this series)?  If you did, you would have gotten a warning about res 
> being used without being initialized.

Oops!  My apologies, I didn't read the code closely enough.  Sorry.

For all the ehci, ohci, and uhci changes in this series:

Acked-by: Alan Stern <stern@...land.harvard.edu>

Alan Stern