linux-kernel - Re: [PATCH v5] i2c: imx-lpi2c: return -EINVAL when i2c peripheral clk doesn't work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230726145823.y67dylomsgblaaww@intel.intel>
Date:   Wed, 26 Jul 2023 16:58:23 +0200
From:   Andi Shyti <andi.shyti@...nel.org>
To:     carlos.song@....com
Cc:     aisheng.dong@....com, shawnguo@...nel.org, s.hauer@...gutronix.de,
        kernel@...gutronix.de, festevam@...il.com, xiaoning.wang@....com,
        haibo.chen@....com, linux-imx@....com, linux-i2c@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5] i2c: imx-lpi2c: return -EINVAL when i2c peripheral
 clk doesn't work

Hi Carlos,

On Wed, Jul 26, 2023 at 05:22:38PM +0800, carlos.song@....com wrote:
> From: Carlos Song <carlos.song@....com>
> 
> On MX8X platforms, the default clock rate is 0 if without explicit
> clock setting in dts nodes. I2c can't work when i2c peripheral clk
> rate is 0.
> 
> Add a i2c peripheral clk rate check before configuring the clock
> register. When i2c peripheral clk rate is 0 and directly return
> -EINVAL.
> 
> Signed-off-by: Carlos Song <carlos.song@....com>

you are missing here:

Acked-by: Dong Aisheng <Aisheng.dong@....com>

You can also add:

Reviewed-by: Andi Shyti <andi.shyti@...nel.org> 

(no need to resend)

Thanks!
Andi