[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20230726092238.3424116-1-carlos.song@nxp.com>
Date: Wed, 26 Jul 2023 17:22:38 +0800
From: carlos.song@....com
To: andi.shyti@...nel.org, aisheng.dong@....com, shawnguo@...nel.org,
s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com
Cc: carlos.song@....com, xiaoning.wang@....com, haibo.chen@....com,
linux-imx@....com, linux-i2c@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: [PATCH v5] i2c: imx-lpi2c: return -EINVAL when i2c peripheral clk doesn't work
From: Carlos Song <carlos.song@....com>
On MX8X platforms, the default clock rate is 0 if without explicit
clock setting in dts nodes. I2c can't work when i2c peripheral clk
rate is 0.
Add a i2c peripheral clk rate check before configuring the clock
register. When i2c peripheral clk rate is 0 and directly return
-EINVAL.
Signed-off-by: Carlos Song <carlos.song@....com>
---
Changes for V5:
- modify commit log
- modify Signed-off-by list
---
drivers/i2c/busses/i2c-imx-lpi2c.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c b/drivers/i2c/busses/i2c-imx-lpi2c.c
index c3287c887c6f..150d923ca7f1 100644
--- a/drivers/i2c/busses/i2c-imx-lpi2c.c
+++ b/drivers/i2c/busses/i2c-imx-lpi2c.c
@@ -209,6 +209,9 @@ static int lpi2c_imx_config(struct lpi2c_imx_struct *lpi2c_imx)
lpi2c_imx_set_mode(lpi2c_imx);
clk_rate = clk_get_rate(lpi2c_imx->clks[0].clk);
+ if (!clk_rate)
+ return -EINVAL;
+
if (lpi2c_imx->mode == HS || lpi2c_imx->mode == ULTRA_FAST)
filt = 0;
else
--
2.34.1
Powered by blists - more mailing lists