linux-kernel - Re: [PATCH next 2/5] minmax: Allow min()/max()/clamp() if the arguments have the same signedness.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZMFHs4MV6vUhwn7r@smile.fi.intel.com>
Date:   Wed, 26 Jul 2023 19:20:03 +0300
From:   'Andy Shevchenko' <andriy.shevchenko@...ux.intel.com>
To:     David Laight <David.Laight@...lab.com>
Cc:     'kernel test robot' <lkp@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        'Andrew Morton' <akpm@...ux-foundation.org>,
        "Matthew Wilcox (Oracle)" <willy@...radead.org>,
        Christoph Hellwig <hch@...radead.org>,
        "Jason A. Donenfeld" <Jason@...c4.com>,
        "llvm@...ts.linux.dev" <llvm@...ts.linux.dev>,
        "oe-kbuild-all@...ts.linux.dev" <oe-kbuild-all@...ts.linux.dev>,
        Linux Memory Management List <linux-mm@...ck.org>
Subject: Re: [PATCH next 2/5] minmax: Allow min()/max()/clamp() if the
 arguments have the same signedness.

On Wed, Jul 26, 2023 at 08:30:59AM +0000, David Laight wrote:
> From: kernel test robot
> > Sent: 25 July 2023 16:58
> > 
> > kernel test robot noticed the following build errors:

...

> >    In file included from init/calibrate.c:8:
> > >> include/linux/jiffies.h:427:28: error: call to undeclared function 'static_assert'; ISO C99 and
> > later do not support implicit function declarations [-Wimplicit-function-declaration]
> >      427 |         return jiffies_to_clock_t(max(0L, delta));
> >          |                                   ^
> ...
> >    include/linux/minmax.h:29:3: note: expanded from macro '__cmp_once'
> >       29 |                 static_assert(__types_ok(x, y),         \
> 
> This is fixed by the earlier patch:
> [PATCH v1 1/1] minmax: Fix header inclusions
> 
> which adds #include <linux/build_bug.h> and thus defines static_assert().
> 
> Can I just assume that will be applied?

You can test that and reply there with your Tested-by there, it will help it
to be applied.

-- 
With Best Regards,
Andy Shevchenko