linux-kernel - Re: [PATCH -next] samples/hw_breakpoint: mark sample

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZMFjWSR4+KudR+gE@bombadil.infradead.org>
Date:   Wed, 26 Jul 2023 11:18:01 -0700
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Chen Jiahao <chenjiahao16@...wei.com>
Cc:     linux-kernel@...r.kernel.org, tj@...nel.org, fweisbec@...il.com,
        pmladek@...e.com, rongtao@...tc.cn
Subject: Re: [PATCH -next] samples/hw_breakpoint: mark sample_hbp as static

On Wed, Jul 26, 2023 at 10:17:59AM +0000, Chen Jiahao wrote:
> There is a sparse warning shown as below:
> 
> samples/hw_breakpoint/data_breakpoint.c:24:19: warning:
> symbol 'sample_hbp' was not declared. Should it be static?
> 
> Since 'sample_hbp' is only called within data_breakpoint.c,
> mark it as static to fix the warning.
> 
> Fixes: 44ee63587dce ("percpu: Add __percpu sparse annotations to hw_breakpoint")
> Signed-off-by: Chen Jiahao <chenjiahao16@...wei.com>

Thanks, applied and pushed.

  Luis