linux-kernel - Re: [PATCH V1 2/2] scsi: ufs: ufs-qcom: check host controller state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <qlxiohqdw52tb3d7duvv3rlusfzo6n73wipmeracchbp7ajrzz@d6ebtuqaldsw>
Date:   Tue, 25 Jul 2023 22:34:18 -0700
From:   Bjorn Andersson <andersson@...nel.org>
To:     Nitin Rawat <quic_nitirawa@...cinc.com>
Cc:     powen.kao@...iatek.com, bvanassche@....org,
        alim.akhtar@...sung.com, adrian.hunter@...el.com,
        jejb@...ux.ibm.com, stanley.chu@...iatek.com,
        asutoshd@...eaurora.org, quic_cang@...cinc.com, mani@...nel.org,
        martin.petersen@...cle.com, beanhuo@...ron.com,
        ebiggers@...gle.com, agross@...nel.org, Arthur.Simchaev@....com,
        konrad.dybcio@...aro.org, quic_ziqichen@...cinc.com,
        quic_nguyenb@...cinc.com, quic_narepall@...cinc.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org,
        Manish Pandey <quic_mapa@...cinc.com>
Subject: Re: [PATCH V1 2/2] scsi: ufs: ufs-qcom: check host controller state

On Wed, Jul 26, 2023 at 12:57:10AM +0530, Nitin Rawat wrote:
> Check host controller state before sending hibern8 command.
> 

Please read https://docs.kernel.org/process/submitting-patches.html#describe-your-changes

> Signed-off-by: Manish Pandey <quic_mapa@...cinc.com>

Please read https://docs.kernel.org/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin

> Signed-off-by: Nitin Rawat <quic_nitirawa@...cinc.com>
> ---
>  drivers/ufs/host/ufs-qcom.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> index 8d6fd4c3324f..95412e98a598 100644
> --- a/drivers/ufs/host/ufs-qcom.c
> +++ b/drivers/ufs/host/ufs-qcom.c
> @@ -1254,6 +1254,10 @@ static int ufs_qcom_clk_scale_notify(struct ufs_hba *hba,
>  	struct ufs_pa_layer_attr *dev_req_params = &host->dev_req_params;
>  	int err = 0;
> 
> +	/* check the host controller state before sending hibern8 cmd */

That is exactly what the two lines does, but the comment does not
provide any insight into why this is done. Keeping a comment here seems
relevant, please make sure that it adds value.

Thanks,
Bjorn

> +	if (!ufshcd_is_hba_active(hba))
> +		return 0;
> +
>  	if (status == PRE_CHANGE) {
>  		err = ufshcd_uic_hibern8_enter(hba);
>  		if (err)
> --
> 2.17.1
>