linux-kernel - Re: [PATCH V1 0/2] Fix hibern8 enter failure during host reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <h6icfhn6xi2iuibrnum5rfre3yeycilkxtowzfu5gwh6mptbua@nhhitqvbwzp4>
Date:   Tue, 25 Jul 2023 22:41:17 -0700
From:   Bjorn Andersson <andersson@...nel.org>
To:     Nitin Rawat <quic_nitirawa@...cinc.com>
Cc:     powen.kao@...iatek.com, bvanassche@....org,
        alim.akhtar@...sung.com, adrian.hunter@...el.com,
        jejb@...ux.ibm.com, stanley.chu@...iatek.com,
        asutoshd@...eaurora.org, quic_cang@...cinc.com, mani@...nel.org,
        martin.petersen@...cle.com, beanhuo@...ron.com,
        ebiggers@...gle.com, agross@...nel.org, Arthur.Simchaev@....com,
        konrad.dybcio@...aro.org, quic_ziqichen@...cinc.com,
        quic_nguyenb@...cinc.com, quic_narepall@...cinc.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH V1 0/2] Fix hibern8 enter failure during host reset

On Wed, Jul 26, 2023 at 12:57:08AM +0530, Nitin Rawat wrote:
> Commit <52a518019c> ("Fix missing clk change notification on host reset")
> added clock scaling notification to ufshcd_host_reset_and_restore.
> This invokes hibern8 enter and exit on qualcomm platform which fails
> because controller is in reset state.
> 
> Fix this by checking the Host controller state before sending
> hibern8 command.
> 
> __ufshcd_wl_resume()
> ufshcd_reset_and_restore()
> ufshcd_host_reset_and_restore()
> ufshcd_scale_clks()
> ufshcd_vops_clk_scale_notify()
> ufs_qcom_clk_scale_notify()
> ufshcd_uic_hibern8_enter()
> 
> Fixes: 52a518019ca1 ("scsi: ufs: core: Fix missing clk change notification on host reset")

Sorry, I missed this before I looked at the individual patches.

The cover-letter is not included in the git history, so this information
will be lost. This explains the reason for patch 2, so please put it
there.

Thanks,
Bjorn