linux-kernel - Re: [PATCH -next] x86/sev: Mark boot_ghcb_page and boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f4b7e173-6e77-b658-be42-eea64e7f2ed9@amd.com>
Date:   Wed, 26 Jul 2023 14:50:16 +0530
From:   "Nikunj A. Dadhania" <nikunj@....com>
To:     Li Zetao <lizetao1@...wei.com>, tglx@...utronix.de,
        mingo@...hat.com, bp@...en8.de
Cc:     x86@...nel.org, hpa@...or.com, thomas.lendacky@....com,
        rppt@...nel.org, kirill.shutemov@...ux.intel.com,
        michael.roth@....com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] x86/sev: Mark boot_ghcb_page and boot_ghcb static

On 7/26/2023 10:36 PM, Li Zetao wrote:
> This patch fixes the following sprse warning:

s/sprse/sparse

> 
> arch/x86/boot/compressed/sev.c:28:13: warning:
> 	symbol boot_ghcb_page was not declared. Should it be static?
> arch/x86/boot/compressed/sev.c:29:13: warning:
> 	symbol boot_ghcb was not declared. Should it be static?
> 
> No functional change intended.
> 
> Signed-off-by: Li Zetao <lizetao1@...wei.com>

With the above nit fixed

Reviewed-by: Nikunj A Dadhania <nikunj@....com>

> ---
>  arch/x86/boot/compressed/sev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/boot/compressed/sev.c b/arch/x86/boot/compressed/sev.c
> index 09dc8c187b3c..323f6298a6b2 100644
> --- a/arch/x86/boot/compressed/sev.c
> +++ b/arch/x86/boot/compressed/sev.c
> @@ -25,8 +25,8 @@
>  #include "error.h"
>  #include "../msr.h"
>  
> -struct ghcb boot_ghcb_page __aligned(PAGE_SIZE);
> -struct ghcb *boot_ghcb;
> +static struct ghcb boot_ghcb_page __aligned(PAGE_SIZE);
> +static struct ghcb *boot_ghcb;
>  
>  /*
>   * Copy a version of this function here - insn-eval.c can't be used in

Regards,
Nikunj