linux-kernel - Re: [PATCH v2] dt-bindings: usb: connector: disallow additional properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <169047762815.1817455.10294109902961650429.robh@kernel.org>
Date:   Thu, 27 Jul 2023 11:09:51 -0600
From:   Rob Herring <robh@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org,
        Bjorn Andersson <andersson@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Guenter Roeck <groeck@...omium.org>,
        Prashant Malani <pmalani@...omium.org>,
        Andy Gross <agross@...nel.org>, linux-arm-msm@...r.kernel.org,
        linux-usb@...r.kernel.org, devicetree@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Wayne Chang <waynec@...dia.com>,
        Benson Leung <bleung@...omium.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        chrome-platform@...ts.linux.dev
Subject: Re: [PATCH v2] dt-bindings: usb: connector: disallow additional
 properties


On Tue, 25 Jul 2023 12:23:25 +0200, Krzysztof Kozlowski wrote:
> USB connector bindings is complete, thus no additional properties should
> be allowed.  Add missing 'reg' property and change additionalProperties
> to false, so the schema will check for anything not unexpected.  This
> also allows to drop the 'reg' from other bindings referencing the
> usb-connector.yaml and make it required.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> ---
> 
> Changes in v2:
> 1. Make usb-connector.yaml additionalProperties:false (Rob)
> 
> v1:
> https://lore.kernel.org/all/20230723071105.40157-1-krzysztof.kozlowski@linaro.org/
> ---
>  .../devicetree/bindings/chrome/google,cros-ec-typec.yaml    | 6 ++----
>  .../devicetree/bindings/connector/usb-connector.yaml        | 5 ++++-
>  .../devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml       | 6 ------
>  Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml | 6 ++----
>  4 files changed, 8 insertions(+), 15 deletions(-)
> 

I didn't not fix the double negative and applied, thanks! ;)