linux-kernel - Re: [PATCH] staging: vme_user: fix check alignment should match open parenthesis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 Jul 2023 19:21:08 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Alexon Oliveira <alexondunkan@...il.com>
Cc:     martyn@...chs.me.uk, manohar.vanga@...il.com,
        linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH] staging: vme_user: fix check alignment should match open
 parenthesis

On Thu, Jul 27, 2023 at 02:08:16PM -0300, Alexon Oliveira wrote:
> On Thu, Jul 27, 2023 at 05:05:03PM +0200, Greg KH wrote:
> > You resolved one warning by replacing it with a different one, that's
> > not good :(
> 
> Well, honestly, I couldn't spot any new issue caused by this patch. At least it was not reported by the checkpatch.pl. The ones that are still showing up were already there. But, to move on, if you think it's more productive, I can fix all warnings and checks reported by the checkpatch.pl and send them over in only one patch. Is it that feasible?

I would have thought you would get a "line is too long" warning, that
didn't happen?

Anyway, no, you can't send a "fix all the issues at once" patch, sorry,
if you do that you will get a message from my patch bot that says:

- Your patch did many different things all at once, making it difficult
  to review.  All Linux kernel patches need to only do one thing at a
  time.  If you need to do multiple things (such as clean up all coding
  style issues in a file/driver), do it in a sequence of patches, each
  one doing only one thing.  This will make it easier to review the
  patches to ensure that they are correct, and to help alleviate any
  merge issues that larger patches can cause.

So please break it up into logical changes.

thanks,

greg k-h