linux-kernel - Re: [PATCH] staging: vme_user: fix check alignment should match open parenthesis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZMKrcvpu3b15Hdif@alolivei-thinkpadt480s.gru.csb>
Date:   Thu, 27 Jul 2023 14:37:54 -0300
From:   Alexon Oliveira <alexondunkan@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     martyn@...chs.me.uk, manohar.vanga@...il.com,
        linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH] staging: vme_user: fix check alignment should match open
 parenthesis

On Thu, Jul 27, 2023 at 07:21:08PM +0200, Greg KH wrote:
> On Thu, Jul 27, 2023 at 02:08:16PM -0300, Alexon Oliveira wrote:
> > On Thu, Jul 27, 2023 at 05:05:03PM +0200, Greg KH wrote:
> > > You resolved one warning by replacing it with a different one, that's
> > > not good :(
> > 
> > Well, honestly, I couldn't spot any new issue caused by this patch. At least it was not reported by the checkpatch.pl. The ones that are still showing up were already there. But, to move on, if you think it's more productive, I can fix all warnings and checks reported by the checkpatch.pl and send them over in only one patch. Is it that feasible?
> 
> I would have thought you would get a "line is too long" warning, that
> didn't happen?
$ pwd
/home/alolivei/git/kernels/staging
$ perl scripts/checkpatch.pl --strict -f drivers/staging/vme_user/vme_bridge.h | grep -i parenthesis
$ 
Nope. I didn't get any of that. Check it out:

$ pwd
/home/alolivei/git/kernels/staging
$ perl scripts/checkpatch.pl --strict -f drivers/staging/vme_user/vme_bridge.h | grep -i parenthesis
$

No more checks/warnings about that. Sure, that are other checks/warnings, but not related to this, and I was intending to fix them in another patch (or multiple patches), because they involve to change the code itself.

> 
> Anyway, no, you can't send a "fix all the issues at once" patch, sorry,
> if you do that you will get a message from my patch bot that says:
> 
> - Your patch did many different things all at once, making it difficult
>   to review.  All Linux kernel patches need to only do one thing at a
>   time.  If you need to do multiple things (such as clean up all coding
>   style issues in a file/driver), do it in a sequence of patches, each
>   one doing only one thing.  This will make it easier to review the
>   patches to ensure that they are correct, and to help alleviate any
>   merge issues that larger patches can cause.
> 

That's what I thought, thank you for the explanation. That's why I sent this "little one" only correcting the check reported by checkpatch.pl related to the code formatting style. At least, as you can see above, the tool is not complaining about that issue anymore, as I made sure to follow up the guidelines on that.

> So please break it up into logical changes.
> 

The logical change of this patch is to fix all the "CHECK: Alignment should match open parenthesis" reported by checkpatch.pl in this specific code in all the lines (11 of them) I reported in my first message.

> thanks,
> 
> greg k-h

Thank you.

Alexon Oliveira