linux-kernel - Re: [PATCH] x86/APM: drop the duplicate APM_MINOR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c4410ce3-e38d-a935-0e5f-6773cdbfe11b@intel.com>
Date:   Thu, 27 Jul 2023 13:06:56 -0700
From:   Sohil Mehta <sohil.mehta@...el.com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        <linux-kernel@...r.kernel.org>
CC:     Jiri Kosina <jikos@...nel.org>, <x86@...nel.org>
Subject: Re: [PATCH] x86/APM: drop the duplicate APM_MINOR_DEV macro

s/drop/Drop

On 7/26/2023 4:49 PM, Randy Dunlap wrote:
> This source file already includes <linux/miscdevice.h>, which contains
> the same macro. It doesn't need to be defined here again.
> 
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Jiri Kosina <jikos@...nel.org>
> Cc: x86@...nel.org
> ---

I am not sure if a Fixes tag is really needed for a redundant macro
definition. If at all, shouldn't it be 874bcd00f520c ("apm-emulation:
move APM_MINOR_DEV to include/linux/miscdevice.h") ?

Either way,
Reviewed-by: Sohil Mehta <sohil.mehta@...el.com>