linux-kernel - Re: [PATCH -next] media: jpeg-core: Remove redundant dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fb0b48af-3bf7-184c-2a99-d1e06fcdabba@gmail.com>
Date:   Thu, 27 Jul 2023 10:47:21 +0200
From:   Andrzej Pietrasiewicz <andrzejtp2010@...il.com>
To:     Ruan Jinjie <ruanjinjie@...wei.com>, jacek.anaszewski@...il.com,
        s.nawrocki@...sung.com, mchehab@...nel.org,
        linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] media: jpeg-core: Remove redundant dev_err()

Thanks!

W dniu 27.07.2023 o 12:06, Ruan Jinjie pisze:
> There is no need to call the dev_err() function directly to print a custom
> message when handling an error from platform_get_irq() function as
> it is going to display an appropriate error message in case of a failure.
> 
> Signed-off-by: Ruan Jinjie <ruanjinjie@...wei.com>

Acked-by: Andrzej Pietrasiewicz <andrzejtp2010@...il.com>

> ---
>   drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c b/drivers/media/platform/samThsung/s5p-jpeg/jpeg-core.c
> index 5e819b8b38a4..d2c4a0178b3c 100644
> --- a/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c
> +++ b/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c
> @@ -2870,10 +2870,8 @@ static int s5p_jpeg_probe(struct platform_device *pdev)
>   
>   	/* interrupt service routine registration */
>   	jpeg->irq = ret = platform_get_irq(pdev, 0);
> -	if (ret < 0) {
> -		dev_err(&pdev->dev, "cannot find IRQ\n");
> +	if (ret < 0)
>   		return ret;
> -	}
>   
>   	ret = devm_request_irq(&pdev->dev, jpeg->irq, jpeg->variant->jpeg_irq,
>   				0, dev_name(&pdev->dev), jpeg);