[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230727100632.2737656-1-ruanjinjie@huawei.com>
Date: Thu, 27 Jul 2023 10:06:32 +0000
From: Ruan Jinjie <ruanjinjie@...wei.com>
To: <andrzejtp2010@...il.com>, <jacek.anaszewski@...il.com>,
<s.nawrocki@...sung.com>, <mchehab@...nel.org>,
<linux-arm-kernel@...ts.infradead.org>,
<linux-media@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC: <ruanjinjie@...wei.com>
Subject: [PATCH -next] media: jpeg-core: Remove redundant dev_err()
There is no need to call the dev_err() function directly to print a custom
message when handling an error from platform_get_irq() function as
it is going to display an appropriate error message in case of a failure.
Signed-off-by: Ruan Jinjie <ruanjinjie@...wei.com>
---
drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c b/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c
index 5e819b8b38a4..d2c4a0178b3c 100644
--- a/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c
+++ b/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c
@@ -2870,10 +2870,8 @@ static int s5p_jpeg_probe(struct platform_device *pdev)
/* interrupt service routine registration */
jpeg->irq = ret = platform_get_irq(pdev, 0);
- if (ret < 0) {
- dev_err(&pdev->dev, "cannot find IRQ\n");
+ if (ret < 0)
return ret;
- }
ret = devm_request_irq(&pdev->dev, jpeg->irq, jpeg->variant->jpeg_irq,
0, dev_name(&pdev->dev), jpeg);
--
2.34.1
Powered by blists - more mailing lists