linux-kernel - Re: [PATCH 05/13] ARM: imx: remove unused mx25

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <0808604b-a26e-43b8-83da-2c3dc12446d2@app.fastmail.com>
Date:   Fri, 28 Jul 2023 17:59:20 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Martin Kaiser" <martin@...ser.cx>
Cc:     "Fabio Estevam" <festevam@...il.com>,
        "Arnd Bergmann" <arnd@...nel.org>, soc@...nel.org,
        "Russell King" <linux@...linux.org.uk>,
        "Bartosz Golaszewski" <brgl@...ev.pl>,
        "Hartley Sweeten" <hsweeten@...ionengravers.com>,
        "Alexander Sverdlin" <alexander.sverdlin@...il.com>,
        "Andre Przywara" <andre.przywara@....com>,
        "Shawn Guo" <shawnguo@...nel.org>,
        "Sascha Hauer" <s.hauer@...gutronix.de>,
        "Pengutronix Kernel Team" <kernel@...gutronix.de>,
        "NXP Linux Team" <linux-imx@....com>,
        "Vladimir Zapolskiy" <vz@...ia.com>,
        "Aaro Koskinen" <aaro.koskinen@....fi>,
        "Janusz Krzysztofik" <jmkrzyszt@...il.com>,
        "Tony Lindgren" <tony@...mide.com>, "Andrew Lunn" <andrew@...n.ch>,
        "Sebastian Hesselbarth" <sebastian.hesselbarth@...il.com>,
        "Gregory Clement" <gregory.clement@...tlin.com>,
        "Daniel Mack" <daniel@...que.org>,
        "Haojian Zhuang" <haojian.zhuang@...il.com>,
        "Robert Jarzmik" <robert.jarzmik@...e.fr>,
        "Viresh Kumar" <vireshk@...nel.org>,
        "Shiraz Hashim" <shiraz.linux.kernel@...il.com>,
        "Sudeep Holla" <sudeep.holla@....com>,
        "Lorenzo Pieralisi" <lpieralisi@...nel.org>,
        "Linus Walleij" <linus.walleij@...aro.org>,
        "Michael Turquette" <mturquette@...libre.com>,
        "Stephen Boyd" <sboyd@...nel.org>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        "Alan Stern" <stern@...land.harvard.edu>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Linux-OMAP <linux-omap@...r.kernel.org>,
        linux-clk@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH 05/13] ARM: imx: remove unused mx25_revision()

On Wed, May 17, 2023, at 17:45, Martin Kaiser wrote:
> Thus wrote Arnd Bergmann (arnd@...db.de):
>
>> I think either way is ok to address the warning. If we wanted to do this
>> properly, the mx{25,27,31,35,5}_revision functions could all be removed
>> and the logic hooked up to imx_set_soc_revision() in the same way that
>> they already use mxc_set_cpu_type() for drivers/soc/imx/soc-imx.c.
>
>> I'll leave it up to you, if you want to merge Martin's patches or
>> a replacement for the soc-imx driver through the imx tree for 6.5,
>> I'll drop my patch from this series, otherwise I'll keep it for now
>> and we can still do it better at later point.
>
> I suggest we merge my patches for imx25 first and then clean up all the
> older imx families to use the common functions.
>
> I've just rebased the patches against today's linux-next. My understanding
> is that they have to go through the clk tree.

This never happened, right? I see that mx25_revision() is still in the
tree without any users, so I can't easily turn on the warning by default
yet. Should I just go ahead and remove it for 5.6, or do you expect to
have your patch ready in time for the merge window?

       Arnd