[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <CUE18VURE744.1E29WQ8EU666G@seitikki>
Date: Fri, 28 Jul 2023 18:55:56 +0000
From: "Jarkko Sakkinen" <jarkko@...nel.org>
To: "YueHaibing" <yuehaibing@...wei.com>, <dhowells@...hat.com>,
<paul@...l-moore.com>, <jmorris@...ei.org>, <serge@...lyn.com>
Cc: <keyrings@...r.kernel.org>,
<linux-security-module@...r.kernel.org>,
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 -next] keys: Remove unused extern declarations
On Mon Jul 24, 2023 at 2:47 PM UTC, YueHaibing wrote:
> Since commit b2a4df200d57 ("KEYS: Expand the capacity of a keyring")
> iterate_over_keyring() is never used, so can be removed.
>
> And commit b5f545c880a2 ("[PATCH] keys: Permit running process to instantiate keys")
> left behind keyring_search_instkey().
>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
Please use the fixes tag properly.
> ---
> v2: Also remove keyring_search_instkey()
> ---
> security/keys/internal.h | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/security/keys/internal.h b/security/keys/internal.h
> index 3c1e7122076b..471cf36dedc0 100644
> --- a/security/keys/internal.h
> +++ b/security/keys/internal.h
> @@ -109,13 +109,6 @@ extern void __key_link_end(struct key *keyring,
> extern key_ref_t find_key_to_update(key_ref_t keyring_ref,
> const struct keyring_index_key *index_key);
>
> -extern struct key *keyring_search_instkey(struct key *keyring,
> - key_serial_t target_id);
> -
> -extern int iterate_over_keyring(const struct key *keyring,
> - int (*func)(const struct key *key, void *data),
> - void *data);
> -
> struct keyring_search_context {
> struct keyring_index_key index_key;
> const struct cred *cred;
> --
> 2.34.1
BR, Jarkko
Powered by blists - more mailing lists