lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <a6826fc1-3319-9ca6-4c25-61703424f052@huawei.com>
Date:   Sat, 29 Jul 2023 10:40:40 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     Jarkko Sakkinen <jarkko@...nel.org>, <dhowells@...hat.com>,
        <paul@...l-moore.com>, <jmorris@...ei.org>, <serge@...lyn.com>
CC:     <keyrings@...r.kernel.org>,
        <linux-security-module@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 -next] keys: Remove unused extern declarations

On 2023/7/29 2:55, Jarkko Sakkinen wrote:
> On Mon Jul 24, 2023 at 2:47 PM UTC, YueHaibing wrote:
>> Since commit b2a4df200d57 ("KEYS: Expand the capacity of a keyring")
>> iterate_over_keyring() is never used, so can be removed.
>>
>> And commit b5f545c880a2 ("[PATCH] keys: Permit running process to instantiate keys")
>> left behind keyring_search_instkey().
>>
>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> 
> Please use the fixes tag properly.

OK, will add fixes tag in v3.
> 
>> ---
>> v2: Also remove keyring_search_instkey()
>> ---
>>  security/keys/internal.h | 7 -------
>>  1 file changed, 7 deletions(-)
>>
>> diff --git a/security/keys/internal.h b/security/keys/internal.h
>> index 3c1e7122076b..471cf36dedc0 100644
>> --- a/security/keys/internal.h
>> +++ b/security/keys/internal.h
>> @@ -109,13 +109,6 @@ extern void __key_link_end(struct key *keyring,
>>  extern key_ref_t find_key_to_update(key_ref_t keyring_ref,
>>  				    const struct keyring_index_key *index_key);
>>  
>> -extern struct key *keyring_search_instkey(struct key *keyring,
>> -					  key_serial_t target_id);
>> -
>> -extern int iterate_over_keyring(const struct key *keyring,
>> -				int (*func)(const struct key *key, void *data),
>> -				void *data);
>> -
>>  struct keyring_search_context {
>>  	struct keyring_index_key index_key;
>>  	const struct cred	*cred;
>> -- 
>> 2.34.1
> 
> 
> BR, Jarkko
> .
> 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ