[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8c9977ea-a6d5-893b-cb00-66e6007d0935@redhat.com>
Date: Fri, 28 Jul 2023 12:30:40 +0200
From: David Hildenbrand <david@...hat.com>
To: Kemeng Shi <shikemeng@...weicloud.com>, akpm@...ux-foundation.org,
linux-mm@...ck.org, linux-kernel@...r.kernel.org,
baolin.wang@...ux.alibaba.com, mgorman@...hsingularity.net,
willy@...radead.org
Subject: Re: [PATCH 7/8] mm/compaction: remove unnecessary return for void
function
On 28.07.23 19:10, Kemeng Shi wrote:
> Remove unnecessary return for void function
>
> Signed-off-by: Kemeng Shi <shikemeng@...weicloud.com>
> ---
> mm/compaction.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/mm/compaction.c b/mm/compaction.c
> index 6052cb519de1..188d610eb3b6 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -1420,8 +1420,6 @@ fast_isolate_around(struct compact_control *cc, unsigned long pfn)
> /* Skip this pageblock in the future as it's full or nearly full */
> if (start_pfn == end_pfn)
> set_pageblock_skip(page);
> -
> - return;
> }
>
> /* Search orders in round-robin fashion */
> @@ -2863,7 +2861,7 @@ int compaction_register_node(struct node *node)
>
> void compaction_unregister_node(struct node *node)
> {
> - return device_remove_file(&node->dev, &dev_attr_compact);
> + device_remove_file(&node->dev, &dev_attr_compact);
> }
> #endif /* CONFIG_SYSFS && CONFIG_NUMA */
>
Reviewed-by: David Hildenbrand <david@...hat.com>
--
Cheers,
David / dhildenb
Powered by blists - more mailing lists