[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <06d566cc-fa03-f68f-e0a4-236567ae5684@redhat.com>
Date: Fri, 28 Jul 2023 12:33:10 +0200
From: David Hildenbrand <david@...hat.com>
To: Kemeng Shi <shikemeng@...weicloud.com>, akpm@...ux-foundation.org,
linux-mm@...ck.org, linux-kernel@...r.kernel.org,
baolin.wang@...ux.alibaba.com, mgorman@...hsingularity.net,
willy@...radead.org
Subject: Re: [PATCH 8/8] mm/compaction: only set skip flag if
cc->no_set_skip_hint is false
On 28.07.23 19:10, Kemeng Shi wrote:
> Keep the same logic as update_pageblock_skip, only set skip if
> no_set_skip_hint is false which is more reasonable.
>
> Signed-off-by: Kemeng Shi <shikemeng@...weicloud.com>
> ---
> mm/compaction.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/compaction.c b/mm/compaction.c
> index 188d610eb3b6..6841c0496223 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -1418,7 +1418,7 @@ fast_isolate_around(struct compact_control *cc, unsigned long pfn)
> isolate_freepages_block(cc, &start_pfn, end_pfn, &cc->freepages, 1, false);
>
> /* Skip this pageblock in the future as it's full or nearly full */
> - if (start_pfn == end_pfn)
> + if (start_pfn == end_pfn && !cc->no_set_skip_hint)
> set_pageblock_skip(page);
> }
>
LGTM, although I am not an expert on that code.
Reviewed-by: David Hildenbrand <david@...hat.com>
--
Cheers,
David / dhildenb
Powered by blists - more mailing lists