[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <09bd1388-02aa-32c7-319e-d7150a0f3e9c@linaro.org>
Date: Fri, 28 Jul 2023 12:17:18 +0100
From: Tudor Ambarus <tudor.ambarus@...aro.org>
To: Varshini Rajendran <varshini.rajendran@...rochip.com>,
herbert@...dor.apana.org.au, davem@...emloft.net,
robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
conor+dt@...nel.org, nicolas.ferre@...rochip.com,
alexandre.belloni@...tlin.com, claudiu.beznea@...rochip.com,
linux-crypto@...r.kernel.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 11/50] dt-bindings: crypto: add sam9x7 in Atmel TDES
Hi,
On 7/28/23 11:24, Varshini Rajendran wrote:
> Add DT bindings for atmel TDES.
NACK. The atmel crypto drivers check the version at runtime and
fill a capabilities structure based on the version identified.
There's a single compatible regardless of the version of the IP
used until now, why do you want to change it?
Please describe what motivated you to write this patch. Some people
can't take seriously a patch if it misses a proper description and
they just ignore it. Maybe it is worth re-reading:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes
Cheers,
ta
>
> Signed-off-by: Varshini Rajendran <varshini.rajendran@...rochip.com>
> ---
> .../devicetree/bindings/crypto/atmel,at91sam9g46-tdes.yaml | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-tdes.yaml b/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-tdes.yaml
> index 3d6ed24b1b00..6a441f79efea 100644
> --- a/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-tdes.yaml
> +++ b/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-tdes.yaml
> @@ -12,7 +12,11 @@ maintainers:
>
> properties:
> compatible:
> - const: atmel,at91sam9g46-tdes
> + oneOf:
> + - const: atmel,at91sam9g46-tdes
> + - items:
> + - const: microchip,sam9x7-tdes
> + - const: atmel,at91sam9g46-tdes
>
> reg:
> maxItems: 1
Powered by blists - more mailing lists