linux-kernel - Re: [PATCH v3] cdx: add MSI support for CDX bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <394f79a7-e0da-a72c-2a09-c68c3cde5f1f@amd.com>
Date:   Fri, 28 Jul 2023 17:02:23 +0530
From:   "Gupta, Nipun" <nipun.gupta@....com>
To:     gregkh@...uxfoundation.org, maz@...nel.org, tglx@...utronix.de,
        jgg@...pe.ca, linux-kernel@...r.kernel.org
Cc:     git@....com, harpreet.anand@....com,
        pieter.jansen-van-vuuren@....com, nikhil.agarwal@....com,
        michal.simek@....com, abhijit.gangurde@....com
Subject: Re: [PATCH v3] cdx: add MSI support for CDX bus

Hi Thomas,

Do you have any further comments on this patch. Can you please help in 
review of this version of the patch?

Thanks,
Nipun

On 7/10/2023 4:58 PM, Nipun Gupta wrote:
> Add CDX-MSI domain per CDX controller with gic-its domain as
> a parent, to support MSI for CDX devices. CDX devices allocate
> MSIs from the CDX domain. Also, introduce APIs to alloc and free
> IRQs for CDX domain.
> 
> In CDX subsystem firmware is a controller for all devices and
> their configuration. CDX bus controller sends all the write_msi_msg
> commands to firmware running on RPU and the firmware interfaces with
> actual devices to pass this information to devices
> 
> Since, CDX controller is the only way to communicate with the Firmware
> for MSI write info, CDX domain per controller required in contrast to
> having a CDX domain per device.
> 
> Co-developed-by: Nikhil Agarwal <nikhil.agarwal@....com>
> Signed-off-by: Nikhil Agarwal <nikhil.agarwal@....com>
> Co-developed-by: Abhijit Gangurde <abhijit.gangurde@....com>
> Signed-off-by: Abhijit Gangurde <abhijit.gangurde@....com>
> Signed-off-by: Nipun Gupta <nipun.gupta@....com>
> Reviewed-by: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@....com>
> Tested-by: Nikhil Agarwal <nikhil.agarwal@....com>
> ---
> 
> Changes v2->v3:
> - Rebased on Linux 6.5rc1
> - Used FW provided 'msi_dev_id' as device ID for GIC instead of 'req_id'.