linux-kernel - Re: [PATCH] csky: fix old style declaration in module.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJF2gTTC0BTOyWH4Zod1oRQaUpS9dE-6=otfpGOPcCcffrHohQ@mail.gmail.com>
Date:   Sat, 29 Jul 2023 12:59:13 +0800
From:   Guo Ren <guoren@...nel.org>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Arnd Bergmann <arnd@...db.de>, linux-csky@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] csky: fix old style declaration in module.c

Thx Arnd,

Reviewed-by: Guo Ren <guoren@...nel.org>

You could directly put it in your next tree. If you need me to do
that, please don't hesitate to let me know.

On Wed, Jul 26, 2023 at 10:57 PM Arnd Bergmann <arnd@...nel.org> wrote:
>
> From: Arnd Bergmann <arnd@...db.de>
>
> With W=1, gcc warns about the inline keyword in the wrong place:
>
> arch/csky/kernel/module.c:43:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  arch/csky/kernel/module.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/csky/kernel/module.c b/arch/csky/kernel/module.c
> index f11b3e5733448..0b56a8cd12a3d 100644
> --- a/arch/csky/kernel/module.c
> +++ b/arch/csky/kernel/module.c
> @@ -40,7 +40,7 @@ static void jsri_2_lrw_jsr(uint32_t *location)
>         }
>  }
>  #else
> -static void inline jsri_2_lrw_jsr(uint32_t *location)
> +static inline void jsri_2_lrw_jsr(uint32_t *location)
>  {
>         return;
>  }
> --
> 2.39.2
>


-- 
Best Regards
 Guo Ren