[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZMSdUS37BD5b/dn7@mail.google.com>
Date: Sat, 29 Jul 2023 17:02:09 +1200
From: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@...il.com>
To: masahiroy@...nel.org, bgray@...ux.ibm.com, ajd@...ux.ibm.com,
n.schier@....de
Cc: paulo.miguel.almeida.rodenas@...il.com,
linux-kernel@...r.kernel.org, keescook@...omium.org
Subject: [PATCH] [next] initramfs: Parse KBUILD_BUILD_TIMESTAMP as UTC date
When KBUILD_BUILD_TIMESTAMP is specified, the date command will parse
it to Unix Epoch time in UTC. However, the date command is
timezone-aware so it will convert from the local timezone to UTC first
which hits some of the sanity checks added on commit 5efb685bb3af1
("initramfs: Check negative timestamp to prevent broken cpio archive")
This creates an edge case for the UTC+<N> part of the world. For instance
- In New Zealand (UTC+12:00):
$ date -d"1970-01-01" +%s
-43200
$ make KBUILD_BUILD_TIMESTAMP=1970-01-01
make[1]: Entering directory '<snip>/linux/'
GEN Makefile
DESCEND objtool
INSTALL libsubcmd_headers
CALL ../scripts/checksyscalls.sh
GEN usr/initramfs_data.cpio
ERROR: Timestamp out of range for cpio format
make[4]: *** [../usr/Makefile:76: usr/initramfs_data.cpio] Error 1
- In Seattle, WA (UTC-07:00):
$ date -d"1970-01-01" +%s
32400
$ make KBUILD_BUILD_TIMESTAMP=1970-01-01
<builds fine>
Parse KBUILD_BUILD_TIMESTAMP date string as UTC so no localtime
conversion is done which fixes the edge case aforementioned.
Signed-off-by: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@...il.com>
---
usr/gen_initramfs.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/usr/gen_initramfs.sh b/usr/gen_initramfs.sh
index 14b5782f961a..a90316d9a080 100755
--- a/usr/gen_initramfs.sh
+++ b/usr/gen_initramfs.sh
@@ -221,7 +221,7 @@ while [ $# -gt 0 ]; do
shift
;;
"-d") # date for file mtimes
- timestamp="$(date -d"$1" +%s || :)"
+ timestamp="$(date -d"$1" -u +%s || :)"
if test -n "$timestamp"; then
timestamp="-t $timestamp"
fi
--
2.40.1
Powered by blists - more mailing lists