linux-kernel - Re: [PATCH 4/4] power: supply: Add driver for pm8916 lbc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 29 Jul 2023 13:28:14 +0800
From:   kernel test robot <lkp@...el.com>
To:     Nikita Travkin <nikita@...n.ru>,
        Sebastian Reichel <sre@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, Nikita Travkin <nikita@...n.ru>
Subject: Re: [PATCH 4/4] power: supply: Add driver for pm8916 lbc

Hi Nikita,

kernel test robot noticed the following build warnings:

[auto build test WARNING on d7b3af5a77e8d8da28f435f313e069aea5bcf172]

url:    https://github.com/intel-lab-lkp/linux/commits/Nikita-Travkin/dt-bindings-power-supply-Add-pm8916-VM-BMS/20230729-013044
base:   d7b3af5a77e8d8da28f435f313e069aea5bcf172
patch link:    https://lore.kernel.org/r/20230728-pm8916-bms-lbc-v1-4-56da32467487%40trvn.ru
patch subject: [PATCH 4/4] power: supply: Add driver for pm8916 lbc
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20230729/202307291336.Zxmj8R1g-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230729/202307291336.Zxmj8R1g-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307291336.Zxmj8R1g-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/power/supply/pm8916_lbc.c: In function 'pm8916_lbc_charger_get_property':
>> drivers/power/supply/pm8916_lbc.c:130:22: warning: unused variable 'tmp' [-Wunused-variable]
     130 |         unsigned int tmp;
         |                      ^~~
>> drivers/power/supply/pm8916_lbc.c:129:13: warning: unused variable 'ret' [-Wunused-variable]
     129 |         int ret = 0;
         |             ^~~


vim +/tmp +130 drivers/power/supply/pm8916_lbc.c

   123	
   124	static int pm8916_lbc_charger_get_property(struct power_supply *psy,
   125						   enum power_supply_property psp,
   126						   union power_supply_propval *val)
   127	{
   128		struct pm8916_lbc_charger *chg = power_supply_get_drvdata(psy);
 > 129		int ret = 0;
 > 130		unsigned int tmp;
   131	
   132		switch (psp) {
   133		case POWER_SUPPLY_PROP_ONLINE:
   134			val->intval = chg->online;
   135			return 0;
   136	
   137		case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE_MAX:
   138			val->intval = chg->charge_voltage_max;
   139			return 0;
   140	
   141		case POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT:
   142			val->intval = chg->charge_current_max;
   143			return 0;
   144	
   145		default:
   146			return -EINVAL;
   147		};
   148	}
   149	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki