[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230729-facecloth-trembling-3311ca245505@spud>
Date: Sat, 29 Jul 2023 11:03:18 +0100
From: Conor Dooley <conor@...nel.org>
To: Nikita Travkin <nikita@...n.ru>
Cc: Sebastian Reichel <sre@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>, linux-pm@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: power: supply: Add pm8916 VM-BMS
On Fri, Jul 28, 2023 at 10:19:30PM +0500, Nikita Travkin wrote:
> Qualcomm Voltage Mode BMS is a battery monitoring block in PM8916 PMIC.
> Document it's DT binding.
>
> Signed-off-by: Nikita Travkin <nikita@...n.ru>
> ---
> .../bindings/power/supply/qcom,pm8916-bms-vm.yaml | 64 ++++++++++++++++++++++
> 1 file changed, 64 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/power/supply/qcom,pm8916-bms-vm.yaml b/Documentation/devicetree/bindings/power/supply/qcom,pm8916-bms-vm.yaml
> new file mode 100644
> index 000000000000..455973d46862
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/qcom,pm8916-bms-vm.yaml
> @@ -0,0 +1,64 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/power/supply/qcom,pm8916-bms-vm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Voltage Mode BMS
> +
> +maintainers:
> + - Nikita Travkin <nikita@...n.ru>
> +
> +description:
> + Voltage Mode BMS is a hardware block found in some Qualcomm PMICs
> + such as pm8916. This block performs battery voltage monitoring.
> +
> +allOf:
> + - $ref: power-supply.yaml#
> +
> +properties:
> + compatible:
> + const: qcom,pm8916-bms-vm
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + items:
> + - description: FIFO update done
You don't need items: here since you only have one - const: will do.
> + interrupt-names:
> + items:
> + - const: fifo
Same here, but do you really need a name, when you have only one
interrupt?
Thanks,
Conor.
> +
> + monitored-battery: true
> +
> + power-supplies: true
> +
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - interrupt-names
> + - monitored-battery
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + pmic {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + battery@...0 {
> + compatible = "qcom,pm8916-bms-vm";
> + reg = <0x4000>;
> + interrupts = <0x0 0x40 4 IRQ_TYPE_EDGE_RISING>;
> + interrupt-names = "fifo";
> +
> + monitored-battery = <&battery>;
> + power-supplies = <&pm8916_charger>;
> + };
> + };
>
> --
> 2.41.0
>
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists