[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230729-splatter-garland-495a414c323e@spud>
Date: Sat, 29 Jul 2023 13:10:35 +0100
From: Conor Dooley <conor@...nel.org>
To: Nikita Travkin <nikita@...n.ru>
Cc: Sebastian Reichel <sre@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>, linux-pm@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: power: supply: Add pm8916 VM-BMS
On Sat, Jul 29, 2023 at 05:06:14PM +0500, Nikita Travkin wrote:
> Conor Dooley писал(а) 29.07.2023 15:03:
> > On Fri, Jul 28, 2023 at 10:19:30PM +0500, Nikita Travkin wrote:
> >> + interrupt-names:
> >> + items:
> >> + - const: fifo
> >
> > Same here, but do you really need a name, when you have only one
> > interrupt?
> >
>
> Hm, thinking of this more, the hardware actually has more than one
> interrupt, even though this one seems to be the only really useful
> one. Would a better way forward be to list all of them
Yes.
> (and fix
> the driver to get the value by it's name)
It's not a fix to do that, the order of the interrupts is not variable,
so there's nothing wrong with using the indices. You can do it if you
like.
> or it would be
> acceptable to leave the names here and extend the list at a later
> date when (if ever) other interrupts are needed?
If you know what they are, please describe them now, even if the driver
does not use them (yet).
Thanks,
Conor.
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists