[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20230729215753.eb0057f6559fa1d8749c80a2@kernel.org>
Date: Sat, 29 Jul 2023 21:57:53 +0900
From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Peter Zijlstra <peterz@...radead.org>,
Petr Pavlu <petr.pavlu@...e.com>, tglx@...utronix.de,
mingo@...hat.com, bp@...en8.de, dave.hansen@...ux.intel.com,
hpa@...or.com, samitolvanen@...gle.com, x86@...nel.org,
linux-trace-kernel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] kprobes: Prohibit probing on CFI preamble symbol
On Fri, 28 Jul 2023 18:49:13 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:
> On Tue, 11 Jul 2023 10:50:47 +0900
> "Masami Hiramatsu (Google)" <mhiramat@...nel.org> wrote:
>
> > From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
> >
> > Do not allow to probe on "__cfi_" or "__pfx_" started symbol, because those
> > are used for CFI and not executed. Probing it will break the CFI.
> >
> > Signed-off-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>
>
> Reviewed-by: Steven Rostedt (Google) <rostedt@...dmis.org>
Thanks! I will pick this for probes/fixes.
>
> -- Steve
>
> > ---
> > Changes in v2:
> > - Check "__pfx_" prefix functions too.
> > - Make the check unconditional.
> > ---
> > kernel/kprobes.c | 14 +++++++++++++-
> > 1 file changed, 13 insertions(+), 1 deletion(-)
> >
--
Masami Hiramatsu (Google) <mhiramat@...nel.org>
Powered by blists - more mailing lists