[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <64c7fcfa3d428_17de01294e8@willemb.c.googlers.com.notmuch>
Date: Mon, 31 Jul 2023 14:27:06 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Gustavo Luiz Duarte <gustavold@...il.com>, netdev@...r.kernel.org
Cc: "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
David Ahern <dsahern@...nel.org>,
Breno Leitao <leitao@...ian.org>,
Willem de Bruijn <willemb@...gle.com>,
linux-kernel@...r.kernel.org,
Willem de Bruijn <willemdebruijn.kernel@...il.com>
Subject: RE: [PATCH] net: ipmr: Call ipmr_ioctl() directly from
ipmr_sk_ioctl()
Gustavo Luiz Duarte wrote:
> Call ipmr_ioctl()/ip6mr_ioctl() directly from ipmr_sk_ioctl()/ip6mr_sk_ioctl()
> and avoid sk_prot->ioctl function pointer indirection.
>
> Also, delete the sock_ioctl_inout() helper as it is no longer needed.
>
> Signed-off-by: Gustavo Luiz Duarte <gustavold@...il.com>
> Suggested-by: Willem de Bruijn <willemdebruijn.kernel@...il.com>
> ---
> include/linux/mroute6.h | 33 ++++++++++++++++++++++++++-------
> include/net/sock.h | 2 --
> net/core/sock.c | 20 --------------------
> net/ipv4/ipmr.c | 33 ++++++++++++++++++++++++++-------
> 4 files changed, 52 insertions(+), 36 deletions(-)
The helper function does save some LoC, it seems.
My comment came during review of the series. Now that that is in,
fine to leave as is, imho.
Powered by blists - more mailing lists