linux-kernel - Re: ksys_sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 31 Jul 2023 20:27:17 +0200
From:   "Wysocki, Rafael J" <rafael.j.wysocki@...el.com>
To:     Christoph Hellwig <hch@...radead.org>
CC:     Christian Brauner <christian@...uner.io>,
        Andrey Grodzovsky <andrey.grodzovsky@....com>,
        <linux-kernel@...r.kernel.org>, <linux-fsdevel@...r.kernel.org>,
        Alex Deucher <alexander.deucher@....com>,
        Hawking Zhang <Hawking.Zhang@....com>,
        Harry Pan <harry.pan@...el.com>, <linux-pm@...r.kernel.org>
Subject: Re: ksys_sync_helper

On 7/31/2023 9:20 AM, Christoph Hellwig wrote:
> Guys,
>
> why did b5dee3130bb4014 add a magic export for sync functionality
> that wrapps VFS code in a weird way, and then exports it (without
> even adding a user in that commit)?   This kind of functionality
> needs to be exported from the VFS, and only with ACKs?

OK, I'll remember about this.


> With this
> and commit d5ea093eebf022e now we end up with a random driver (amdgpu)
> syncing all file systems for absolutely no good reason.

Sorry about that.

The problematic commit should still revert more or less cleanly, so 
please do that if that's what you need.