[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <abe91475c7f9e3483405c6096006b2a9.paul@paul-moore.com>
Date: Mon, 31 Jul 2023 16:07:38 -0400
From: Paul Moore <paul@...l-moore.com>
To: Khadija Kamran <kamrankhadijadj@...il.com>
Cc: Alison Schofield <alison.schofield@...el.com>,
ztarkhani@...rosoft.com, James Morris <jmorris@...ei.org>,
"Serge E. Hallyn" <serge@...lyn.com>,
linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lsm: add comment block for security_sk_classify_flow LSM hook
On Jul 31, 2023 Khadija Kamran wrote:
>
> security_sk_classify_flow LSM hook has no comment block. Add a comment
> block with a brief description of LSM hook and its function parameters.
>
> Signed-off-by: Khadija Kamran <kamrankhadijadj@...il.com>
> ---
> security/security.c | 7 +++++++
> 1 file changed, 7 insertions(+)
Thanks Khadija. I did make a small change to your patch (see below)
when merging it into the lsm/next branch.
> diff --git a/security/security.c b/security/security.c
> index d5ff7ff45b77..ffc5519e49cd 100644
> --- a/security/security.c
> +++ b/security/security.c
> @@ -4396,6 +4396,13 @@ void security_sk_clone(const struct sock *sk, struct sock *newsk)
> }
> EXPORT_SYMBOL(security_sk_clone);
>
> +/**
> + * security_sk_classify_flow() - Set a flow's secid based on socket
> + * @sk: original socket
As has been pointed out previously, there is a double-space between
"sk:" and "original socket".
> + * @flic: target flow
> + *
> + * Set the target flow's secid to socket's secid.
> + */
> void security_sk_classify_flow(struct sock *sk, struct flowi_common *flic)
> {
> call_void_hook(sk_getsecid, sk, &flic->flowic_secid);
> --
> 2.34.1
--
paul-moore.com
Powered by blists - more mailing lists