linux-kernel - Re: [PATCH] lsm: add comment block for security_sk_classify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZNCO1hOTKfBwD1zm@gmail.com>
Date:   Mon, 7 Aug 2023 11:27:34 +0500
From:   Khadija Kamran <kamrankhadijadj@...il.com>
To:     Alison Schofield <alison.schofield@...el.com>
Cc:     ztarkhani@...rosoft.com, Paul Moore <paul@...l-moore.com>,
        James Morris <jmorris@...ei.org>,
        "Serge E. Hallyn" <serge@...lyn.com>,
        linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lsm: add comment block for security_sk_classify_flow LSM
 hook

On Mon, Jul 31, 2023 at 09:56:04AM -0700, Alison Schofield wrote:
> On Mon, Jul 31, 2023 at 07:36:47PM +0500, Khadija Kamran wrote:
> > security_sk_classify_flow LSM hook has no comment block. Add a comment
> > block with a brief description of LSM hook and its function parameters.
> 
> When referring to functions, in the one line commit message, or here
> in the commit log, it is customary to add the parenthesis to be clear
> it is a function name.
> 
> ie. security_sk_classify_flow()
> 
> > 
> > Signed-off-by: Khadija Kamran <kamrankhadijadj@...il.com>
> > ---
> >  security/security.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/security/security.c b/security/security.c
> > index d5ff7ff45b77..ffc5519e49cd 100644
> > --- a/security/security.c
> > +++ b/security/security.c
> > @@ -4396,6 +4396,13 @@ void security_sk_clone(const struct sock *sk, struct sock *newsk)
> >  }
> >  EXPORT_SYMBOL(security_sk_clone);
> >  
> > +/**
> > + * security_sk_classify_flow() - Set a flow's secid based on socket
> > + * @sk:  original socket
>            ^errant space
>

Hey Alison,
Noted. Thank you.

> > + * @flic: target flow
> > + *
> > + * Set the target flow's secid to socket's secid.
> > + */
> >  void security_sk_classify_flow(struct sock *sk, struct flowi_common *flic)
> >  {
> >  	call_void_hook(sk_getsecid, sk, &flic->flowic_secid);
> > -- 
> > 2.34.1
> >