linux-kernel - Re: [PATCH v3 5/8] dt-bindings: arm: qcom,ids: Adjust the position of QCOM_ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <981a79ee-5258-eb76-020a-765f5f39866f@linaro.org>
Date:   Mon, 31 Jul 2023 09:00:16 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Tengfei Fan <quic_tengfan@...cinc.com>, andersson@...nel.org,
        konrad.dybcio@...aro.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org
Cc:     quic_tsoni@...cinc.com, quic_shashim@...cinc.com,
        quic_kaushalk@...cinc.com, quic_tdas@...cinc.com,
        quic_tingweiz@...cinc.com, quic_aiquny@...cinc.com,
        kernel@...cinc.com, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 5/8] dt-bindings: arm: qcom,ids: Adjust the position of
 QCOM_ID_QDU1010

On 31/07/2023 08:13, Tengfei Fan wrote:
> Adjust the position of QCOM_ID_QDU1010, so that there is a coherent
> sequence of numbers.
> 
> Change-Id: Id083e1ecc92c063c1a07a81c66dcb034020964b0

Please run scripts/checkpatch.pl and fix reported warnings. Some
warnings can be ignored, but the code here looks like it needs a fix.
Feel free to get in touch if the warning is not clear.

> ---
>  include/dt-bindings/arm/qcom,ids.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
> index bcbe9ee2cdaf..977c235ed0d9 100644
> --- a/include/dt-bindings/arm/qcom,ids.h
> +++ b/include/dt-bindings/arm/qcom,ids.h
> @@ -249,8 +249,8 @@
>  #define QCOM_ID_SA8775P			534
>  #define QCOM_ID_QRU1000			539
>  #define QCOM_ID_QDU1000			545
> -#define QCOM_ID_QDU1010			587
>  #define QCOM_ID_IPQ5019			569

I don't think this change is needed. Isn't IPQ5019 going away?


Best regards,
Krzysztof