| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1cc36fa4-28b9-3bdc-e6b3-e78d3198f67b@linaro.org>
Date: Mon, 31 Jul 2023 10:47:57 +0200
From: neil.armstrong@...aro.org
To: Huqiang Qin <huqiang.qin@...ogic.com>, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
khilman@...libre.com, jbrunet@...libre.com,
martin.blumenstingl@...glemail.com, linus.walleij@...aro.org
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-gpio@...r.kernel.org
Subject: Re: [PATCH V2 3/3] arm64: dts: Replace the IRQ number with the IRQID
macro definition
On 24/07/2023 08:01, Huqiang Qin wrote:
> Replacing IRQ numbers with IRQID macro definitions makes node properties
> easier to understand and also makes GPIO interrupts easier to use.
>
> Associated platforms:
> - Amlogic Meson-G12A
> - Amlogic Meson-G12B
> - Amlogic Meson-SM1
>
> Signed-off-by: Huqiang Qin <huqiang.qin@...ogic.com>
> ---
>
> V1 -> V2: Include header file changed to amlogic,meson-g12a-gpio-intc.h
>
> arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 1 +
> arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts | 2 +-
> .../boot/dts/amlogic/meson-g12b-bananapi-cm4.dtsi | 2 +-
> arch/arm64/boot/dts/amlogic/meson-g12b-bananapi.dtsi | 2 +-
> .../boot/dts/amlogic/meson-g12b-odroid-go-ultra.dts | 4 ++--
> .../arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 2 +-
> arch/arm64/boot/dts/amlogic/meson-g12b-w400.dtsi | 2 +-
> .../boot/dts/amlogic/meson-sm1-a95xf3-air-gbit.dts | 2 +-
> arch/arm64/boot/dts/amlogic/meson-sm1-bananapi.dtsi | 4 ++--
> arch/arm64/boot/dts/amlogic/meson-sm1-h96-max.dts | 2 +-
> arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi | 2 +-
> arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts | 12 ++++++------
> .../boot/dts/amlogic/meson-sm1-x96-air-gbit.dts | 2 +-
> 13 files changed, 20 insertions(+), 19 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> index 0c49655cc90c..d8b94a3167c3 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> @@ -9,6 +9,7 @@
> #include <dt-bindings/clock/g12a-aoclkc.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include <dt-bindings/interrupt-controller/amlogic,meson-g12a-gpio-intc.h>
> #include <dt-bindings/reset/amlogic,meson-g12a-reset.h>
> #include <dt-bindings/thermal/thermal.h>
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
> index b2bb94981838..c79f3e8d26b7 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
> @@ -344,7 +344,7 @@ external_phy: ethernet-phy@0 {
>
> interrupt-parent = <&gpio_intc>;
> /* MAC_INTR on GPIOZ_14 */
> - interrupts = <26 IRQ_TYPE_LEVEL_LOW>;
> + interrupts = <IRQID_GPIOZ_14 IRQ_TYPE_LEVEL_LOW>;
> };
> };
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-bananapi-cm4.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-bananapi-cm4.dtsi
> index 97e522921b06..428b35e1d79c 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-bananapi-cm4.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-bananapi-cm4.dtsi
> @@ -201,7 +201,7 @@ external_phy: ethernet-phy@0 {
>
> interrupt-parent = <&gpio_intc>;
> /* MAC_INTR on GPIOZ_14 */
> - interrupts = <26 IRQ_TYPE_LEVEL_LOW>;
> + interrupts = <IRQID_GPIOZ_14 IRQ_TYPE_LEVEL_LOW>;
> };
> };
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-bananapi.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-bananapi.dtsi
> index 83709787eb91..c69b0f803916 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-bananapi.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-bananapi.dtsi
> @@ -327,7 +327,7 @@ external_phy: ethernet-phy@0 {
>
> interrupt-parent = <&gpio_intc>;
> /* MAC_INTR on GPIOZ_14 */
> - interrupts = <26 IRQ_TYPE_LEVEL_LOW>;
> + interrupts = <IRQID_GPIOZ_14 IRQ_TYPE_LEVEL_LOW>;
> };
> };
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-go-ultra.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-go-ultra.dts
> index 276e95b34022..eed2a23047ca 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-go-ultra.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-go-ultra.dts
> @@ -380,7 +380,7 @@ rk818: pmic@1c {
> compatible = "rockchip,rk818";
> reg = <0x1c>;
> interrupt-parent = <&gpio_intc>;
> - interrupts = <7 IRQ_TYPE_LEVEL_LOW>; /* GPIOAO_7 */
> + interrupts = <IRQID_GPIOAO_7 IRQ_TYPE_LEVEL_LOW>; /* GPIOAO_7 */
> #clock-cells = <1>;
>
> vcc1-supply = <&vdd_sys>;
> @@ -519,7 +519,7 @@ rk817: pmic@20 {
> reg = <0x20>;
> interrupt-parent = <&gpio_intc>;
>
> - interrupts = <5 IRQ_TYPE_LEVEL_LOW>; /* GPIOAO_5 */
> + interrupts = <IRQID_GPIOAO_5 IRQ_TYPE_LEVEL_LOW>; /* GPIOAO_5 */
>
> vcc1-supply = <&vdd_sys>;
> vcc2-supply = <&vdd_sys>;
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> index 24d0442dffb2..01aa970b2f8c 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> @@ -185,7 +185,7 @@ external_phy: ethernet-phy@0 {
>
> interrupt-parent = <&gpio_intc>;
> /* MAC_INTR on GPIOZ_14 */
> - interrupts = <26 IRQ_TYPE_LEVEL_LOW>;
> + interrupts = <IRQID_GPIOZ_14 IRQ_TYPE_LEVEL_LOW>;
> };
> };
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-w400.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-w400.dtsi
> index b40d2c1002c9..ac8b7178257e 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-w400.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-w400.dtsi
> @@ -269,7 +269,7 @@ external_phy: ethernet-phy@0 {
>
> interrupt-parent = <&gpio_intc>;
> /* MAC_INTR on GPIOZ_14 */
> - interrupts = <26 IRQ_TYPE_LEVEL_LOW>;
> + interrupts = <IRQID_GPIOZ_14 IRQ_TYPE_LEVEL_LOW>;
> };
> };
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-a95xf3-air-gbit.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-a95xf3-air-gbit.dts
> index d1debccdc1c2..95e03bb02af2 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-sm1-a95xf3-air-gbit.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-a95xf3-air-gbit.dts
> @@ -100,7 +100,7 @@ external_phy: ethernet-phy@0 {
>
> interrupt-parent = <&gpio_intc>;
> /* MAC_INTR on GPIOZ_14 */
> - interrupts = <26 IRQ_TYPE_LEVEL_LOW>;
> + interrupts = <IRQID_GPIOZ_14 IRQ_TYPE_LEVEL_LOW>;
> };
> };
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi.dtsi b/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi.dtsi
> index 17045ff81c69..62404743e62d 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi.dtsi
> @@ -45,7 +45,7 @@ key {
> linux,code = <BTN_1>;
> gpios = <&gpio_ao GPIOAO_3 GPIO_ACTIVE_LOW>;
> interrupt-parent = <&gpio_intc>;
> - interrupts = <3 IRQ_TYPE_EDGE_BOTH>;
> + interrupts = <IRQID_GPIOAO_3 IRQ_TYPE_EDGE_BOTH>;
> };
> };
>
> @@ -217,7 +217,7 @@ external_phy: ethernet-phy@0 {
>
> interrupt-parent = <&gpio_intc>;
> /* MAC_INTR on GPIOZ_14 */
> - interrupts = <26 IRQ_TYPE_LEVEL_LOW>;
> + interrupts = <IRQID_GPIOZ_14 IRQ_TYPE_LEVEL_LOW>;
> };
> };
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-h96-max.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-h96-max.dts
> index 0f6660e68e72..ebda1dd30fa6 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-sm1-h96-max.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-h96-max.dts
> @@ -100,7 +100,7 @@ external_phy: ethernet-phy@0 {
>
> interrupt-parent = <&gpio_intc>;
> /* MAC_INTR on GPIOZ_14 */
> - interrupts = <26 IRQ_TYPE_LEVEL_LOW>;
> + interrupts = <IRQID_GPIOZ_14 IRQ_TYPE_LEVEL_LOW>;
> };
> };
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi
> index 2fce44939f45..86b90f44a4b3 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi
> @@ -283,7 +283,7 @@ external_phy: ethernet-phy@0 {
>
> interrupt-parent = <&gpio_intc>;
> /* MAC_INTR on GPIOZ_14 */
> - interrupts = <26 IRQ_TYPE_LEVEL_LOW>;
> + interrupts = <IRQID_GPIOZ_14 IRQ_TYPE_LEVEL_LOW>;
> };
> };
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
> index 9068a334ea57..4f07d6387bb1 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
> @@ -53,7 +53,7 @@ key-1 {
> linux,code = <BTN_0>;
> gpios = <&gpio GPIOH_6 GPIO_ACTIVE_LOW>;
> interrupt-parent = <&gpio_intc>;
> - interrupts = <34 IRQ_TYPE_EDGE_BOTH>;
> + interrupts = <IRQID_GPIOH_6 IRQ_TYPE_EDGE_BOTH>;
> };
>
> key-2 {
> @@ -61,7 +61,7 @@ key-2 {
> linux,code = <BTN_1>;
> gpios = <&gpio GPIOH_7 GPIO_ACTIVE_LOW>;
> interrupt-parent = <&gpio_intc>;
> - interrupts = <35 IRQ_TYPE_EDGE_BOTH>;
> + interrupts = <IRQID_GPIOH_7 IRQ_TYPE_EDGE_BOTH>;
> };
>
> key-3 {
> @@ -69,7 +69,7 @@ key-3 {
> linux,code = <BTN_2>;
> gpios = <&gpio_ao GPIOAO_2 GPIO_ACTIVE_LOW>;
> interrupt-parent = <&gpio_intc>;
> - interrupts = <2 IRQ_TYPE_EDGE_BOTH>;
> + interrupts = <IRQID_GPIOAO_2 IRQ_TYPE_EDGE_BOTH>;
> };
>
> key-mic-mute {
> @@ -78,7 +78,7 @@ key-mic-mute {
> linux,input-type = <EV_SW>;
> gpios = <&gpio_ao GPIOE_2 GPIO_ACTIVE_LOW>;
> interrupt-parent = <&gpio_intc>;
> - interrupts = <99 IRQ_TYPE_EDGE_BOTH>;
> + interrupts = <IRQID_GPIOE_2 IRQ_TYPE_EDGE_BOTH>;
> };
>
> key-power {
> @@ -86,7 +86,7 @@ key-power {
> linux,code = <KEY_POWER>;
> gpios = <&gpio_ao GPIOAO_3 GPIO_ACTIVE_LOW>;
> interrupt-parent = <&gpio_intc>;
> - interrupts = <3 IRQ_TYPE_EDGE_BOTH>;
> + interrupts = <IRQID_GPIOAO_3 IRQ_TYPE_EDGE_BOTH>;
> };
> };
>
> @@ -583,7 +583,7 @@ &uart_A {
> bluetooth {
> compatible = "brcm,bcm43438-bt";
> interrupt-parent = <&gpio_intc>;
> - interrupts = <95 IRQ_TYPE_LEVEL_HIGH>;
> + interrupts = <IRQID_GPIOX_18 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-names = "host-wakeup";
> shutdown-gpios = <&gpio GPIOX_17 GPIO_ACTIVE_HIGH>;
> max-speed = <2000000>;
> diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-x96-air-gbit.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-x96-air-gbit.dts
> index 7e1a74046ba5..6ee406066ee0 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-sm1-x96-air-gbit.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-x96-air-gbit.dts
> @@ -100,7 +100,7 @@ external_phy: ethernet-phy@0 {
>
> interrupt-parent = <&gpio_intc>;
> /* MAC_INTR on GPIOZ_14 */
> - interrupts = <26 IRQ_TYPE_LEVEL_LOW>;
> + interrupts = <IRQID_GPIOZ_14 IRQ_TYPE_LEVEL_LOW>;
> };
> };
>
Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>
Powered by blists - more mailing lists