linux-kernel - RE: [PATCH v2] hwmon: (pmbus/mp2975) Fix PGOOD in READ_STATUS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 31 Jul 2023 09:54:46 +0000
From:   Vadim Pasternak <vadimp@...dia.com>
To:     Naresh Solanki <naresh.solanki@...ements.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Jean Delvare <jdelvare@...e.com>
CC:     Patrick Rudolph <patrick.rudolph@...ements.com>,
        "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2] hwmon: (pmbus/mp2975) Fix PGOOD in READ_STATUS_WORD



> -----Original Message-----
> From: Naresh Solanki <naresh.solanki@...ements.com>
> Sent: Monday, 31 July 2023 12:22
> To: Guenter Roeck <linux@...ck-us.net>; Jean Delvare <jdelvare@...e.com>
> Cc: Vadim Pasternak <vadimp@...dia.com>; Patrick Rudolph
> <patrick.rudolph@...ements.com>; Naresh Solanki
> <Naresh.Solanki@...ements.com>; linux-hwmon@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: [PATCH v2] hwmon: (pmbus/mp2975) Fix PGOOD in
> READ_STATUS_WORD
> 
> From: Patrick Rudolph <patrick.rudolph@...ements.com>
> 
> MP2973 & MP2971 returns PGOOD instead of PB_STATUS_POWER_GOOD_N.
> Fix that in the read_word_data hook.
> MP2975 might be affected but needs verification.

Hi,

According to MP2975 regmap datasheet for STATUS_WORD, bit 11 reports:
 11	 POWER_GOOD_N	1’b0: PG is active.
				1’b1: PG not active has occurred
Is it the same what stays MP2971 and MP2973 docs?

Thanks,
Vadim.

> 
> Signed-off-by: Patrick Rudolph <patrick.rudolph@...ements.com>
> Signed-off-by: Naresh Solanki <Naresh.Solanki@...ements.com>
> ---
>  drivers/hwmon/pmbus/mp2975.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/hwmon/pmbus/mp2975.c
> b/drivers/hwmon/pmbus/mp2975.c index 28f33f4618fa..27bb39370662
> 100644
> --- a/drivers/hwmon/pmbus/mp2975.c
> +++ b/drivers/hwmon/pmbus/mp2975.c
> @@ -297,6 +297,11 @@ static int mp2973_read_word_data(struct i2c_client
> *client, int page,
>  	int ret;
> 
>  	switch (reg) {
> +	case PMBUS_STATUS_WORD:
> +		/* MP2973 & MP2971 returns PGOOD instead of
> PB_STATUS_POWER_GOOD_N. */
> +		ret = pmbus_read_word_data(client, page, phase, reg);
> +		ret ^= PB_STATUS_POWER_GOOD_N;
> +		break;
>  	case PMBUS_OT_FAULT_LIMIT:
>  		ret = mp2975_read_word_helper(client, page, phase, reg,
>  					      GENMASK(7, 0));
> 
> base-commit: cb7022b8976e3c4d12cea2e7bb820a2944e2fd7b
> --
> 2.41.0