linux-kernel - Re: [PATCH] soc: qcom: qmi_encdec: Restrict string length in decode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6920de01-2c32-eae8-2ca8-f04ae3a3bed8@quicinc.com>
Date:   Mon, 31 Jul 2023 15:25:20 +0530
From:   Praveenkumar I <quic_ipkumar@...cinc.com>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>, <agross@...nel.org>,
        <andersson@...nel.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
CC:     <quic_varada@...cinc.com>, <quic_clew@...cinc.com>
Subject: Re: [PATCH] soc: qcom: qmi_encdec: Restrict string length in decode


On 7/31/2023 2:48 PM, Konrad Dybcio wrote:
> On 31.07.2023 11:14, Praveenkumar I wrote:
>> The QMI TLV value for strings in a lot of qmi element info structures
>> account for null terminated strings with MAX_LEN + 1. If a string is
>> actually MAX_LEN + 1 length, this will cause an out of bounds access
>> when the NULL character is appended in decoding.
>>
>> Signed-off-by: Chris Lew <quic_clew@...cinc.com>
>> Signed-off-by: Praveenkumar I <quic_ipkumar@...cinc.com>
>> ---
> Fixes + Cc: stable?
Sure, will add.
>
> Konrad
--
Thanks,
Praveenkumar