linux-kernel - Re: [PATCH] drm/i915: fix application of sizeof to pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87leewxv4a.fsf@intel.com>
Date:   Mon, 31 Jul 2023 12:56:05 +0300
From:   Jani Nikula <jani.nikula@...ux.intel.com>
To:     sunran001@...suo.com, airlied@...il.com, daniel@...ll.ch
Cc:     linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm/i915: fix application of sizeof to pointer

On Thu, 20 Jul 2023, sunran001@...suo.com wrote:
> The coccinelle check report:
> ./drivers/scsi/csiostor/csio_mb.c:1554:46-52: ERROR: application
> of sizeof to pointer

Please don't just assume coccinelle is right, and send "fixes" based on
the cocci reports alone. You need to read and understand the code you're
changing.


BR,
Jani.

>
> Signed-off-by: Ran Sun <sunran001@...suo.com>
> ---
>   drivers/gpu/drm/i915/i915_syncmap.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_syncmap.c 
> b/drivers/gpu/drm/i915/i915_syncmap.c
> index 60404dbb2e9f..4eeaf12be72d 100644
> --- a/drivers/gpu/drm/i915/i915_syncmap.c
> +++ b/drivers/gpu/drm/i915/i915_syncmap.c
> @@ -282,7 +282,7 @@ static noinline int __sync_set(struct i915_syncmap 
> **root, u64 id, u32 seqno)
>   			unsigned int above;
>
>   			/* Insert a join above the current layer */
> -			next = kzalloc(sizeof(*next) + KSYNCMAP * sizeof(next),
> +			next = kzalloc(sizeof(*next) + KSYNCMAP * sizeof(*next),
>   				       GFP_KERNEL);
>   			if (unlikely(!next))
>   				return -ENOMEM;

-- 
Jani Nikula, Intel Open Source Graphics Center