[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a29cf254-80c9-50e6-c723-71a8f03e6e35@pengutronix.de>
Date: Mon, 31 Jul 2023 14:42:14 +0200
From: Ahmad Fatoum <a.fatoum@...gutronix.de>
To: Guido Günther <guido.gunther@...i.sm>,
David Heidelberg <david@...t.cz>
Cc: devicetree@...r.kernel.org, Conor Dooley <conor+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Fabio Estevam <festevam@...il.com>,
Sascha Hauer <s.hauer@...gutronix.de>,
Peng Fan <peng.fan@....com>, linux-kernel@...r.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
NXP Linux Team <linux-imx@....com>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Shawn Guo <shawnguo@...nel.org>,
linux-arm-kernel@...ts.infradead.org, kernel@...i.sm
Subject: Re: [PATCH] arm64: dts: imx8mq-librem5-devkit: switch to vqmmc-supply
Hello David,
Hello Guido,
On 31.07.23 13:32, Guido Günther wrote:
> Hi,
> On Sun, Jul 30, 2023 at 03:10:46PM +0300, David Heidelberg wrote:
>> Resolves following warning:
>> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb: mmc@...50000: Unevaluated properties are not allowed ('power-supply' was unexpected)
>> from schema $id: http://devicetree.org/schemas/mmc/fsl-imx-esdhc.yaml#
>>
>> Cc: kernel@...i.sm
>> Cc: Guido Günther <agx@...xcpu.org>
>> Signed-off-by: David Heidelberg <david@...t.cz>
>> ---
>> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
>> index b3549eae6278..a8b5da3ca08f 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
>> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
>> @@ -1031,7 +1031,7 @@ &usdhc2 {
>> pinctrl-2 = <&pinctrl_usdhc2_200mhz>;
>> bus-width = <4>;
>> vmmc-supply = <®_usdhc2_vmmc>;
>> - power-supply = <&wifi_pwr_en>;
>> + vqmmc-supply = <&wifi_pwr_en>;
>
> From the schematics WIFI_PWR_EN connects to the Wifi card's `W_DISABLE`
> so I don't think vqmmc is correct here. I wonder if there's a better way
> to model that in DT? Any suggestions would be welcome.
I think mmc-pwrseq is what you are after.
Cheers,
Ahmad
>
> Cheers,
> -- Guido
>
>> broken-cd;
>> disable-wp;
>> cap-sdio-irq;
>> --
>> 2.40.1
>>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Powered by blists - more mailing lists