linux-kernel - Re: [PATCH] arm64: dts: imx8mq-librem5-devkit: switch to vqmmc-supply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d724e3e2-cb46-46d4-8499-8e7c745805da@ixit.cz>
Date:   Thu, 10 Aug 2023 07:23:47 +0200
From:   David Heidelberg <david@...t.cz>
To:     Ahmad Fatoum <a.fatoum@...gutronix.de>,
        Guido Günther <guido.gunther@...i.sm>
Cc:     devicetree@...r.kernel.org, Conor Dooley <conor+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Fabio Estevam <festevam@...il.com>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Peng Fan <peng.fan@....com>, linux-kernel@...r.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        NXP Linux Team <linux-imx@....com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Shawn Guo <shawnguo@...nel.org>,
        linux-arm-kernel@...ts.infradead.org, kernel@...i.sm
Subject: Re: [PATCH] arm64: dts: imx8mq-librem5-devkit: switch to vqmmc-supply

On 31/07/2023 14:42, Ahmad Fatoum wrote:
> Hello David,
> Hello Guido,
>
> On 31.07.23 13:32, Guido Günther wrote:
>> Hi,
>> On Sun, Jul 30, 2023 at 03:10:46PM +0300, David Heidelberg wrote:
>>> Resolves following warning:
>>> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb: mmc@...50000: Unevaluated properties are not allowed ('power-supply' was unexpected)
>>> 	from schema $id: http://devicetree.org/schemas/mmc/fsl-imx-esdhc.yaml#
>>>
>>> Cc: kernel@...i.sm
>>> Cc: Guido Günther <agx@...xcpu.org>
>>> Signed-off-by: David Heidelberg <david@...t.cz>
>>> ---
>>>   arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
>>> index b3549eae6278..a8b5da3ca08f 100644
>>> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
>>> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
>>> @@ -1031,7 +1031,7 @@ &usdhc2 {
>>>   	pinctrl-2 = <&pinctrl_usdhc2_200mhz>;
>>>   	bus-width = <4>;
>>>   	vmmc-supply = <&reg_usdhc2_vmmc>;
>>> -	power-supply = <&wifi_pwr_en>;
>>> +	vqmmc-supply = <&wifi_pwr_en>;
>>  From the schematics WIFI_PWR_EN connects to the Wifi card's `W_DISABLE`
>> so I don't think vqmmc is correct here. I wonder if there's a better way
>> to model that in DT? Any suggestions would be welcome.
> I think mmc-pwrseq is what you are after.

Guido sent patch to replace it with `mmc-pwrseq` in 
https://www.spinics.net/lists/kernel/msg4894084.html

-- 
David Heidelberg
Certified Linux Magician