linux-kernel - Re: [PATCH 2/3] dt-bindings: arm: qcom: Add Xiaomi Mi 11 Ultra

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEPPPKvS4G5RUs1Fb0anGUELC8_5eVvG+2ORd_xYupuu1SKGww@mail.gmail.com>
Date:   Thu, 10 Aug 2023 13:26:35 +0800
From:   Sophon Wu <wuxilin123@...il.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        Tony Luck <tony.luck@...el.com>,
        "Guilherme G. Piccoli" <gpiccoli@...lia.com>,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: arm: qcom: Add Xiaomi Mi 11 Ultra

Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> 于2023年8月6日周日 04:11写道：

>On 05/08/2023 19:03, Xilin Wu via B4 Relay wrote:
>> From: Xilin Wu <wuxilin123@...il.com>
>>
>> Add support for Xiaomi Mi 11 Ultra. This commit brings support for:
>> * Front and rear display panels (initialized by bootloader)
>> * USB
>> * UFS
>> * PCIe0
>> * Thermistor sensors
>> * ADSP/CDSP/Modem/SLPI
>> * IR Transmitter
>> * RTC provided by PMK8350
>> * Buttons
>>
>
>...
>
>
>> +/*
>> + * Delete following upstream (sm8350.dtsi) reserved
>> + * memory mappings which are different on this device.
>
>
>> + */
>> +/delete-node/ &pil_adsp_mem;
>> +/delete-node/ &pil_slpi_mem;
>> +/delete-node/ &pil_cdsp_mem;
>> +/delete-node/ &pil_ipa_fw_mem;
>> +/delete-node/ &pil_ipa_gsi_mem;
>> +/delete-node/ &pil_gpu_mem;
>> +/delete-node/ &pil_spss_mem;
>> +/delete-node/ &pil_modem_mem;
>> +/delete-node/ &rmtfs_mem;
>> +/delete-node/ &pil_trustedvm_mem;
>> +/delete-node/ &removed_mem;
>> +
>> +/ {
>> +    model = "Xiaomi Mi 11 Ultra";
>> +    compatible = "xiaomi,star", "qcom,sm8350";
>> +    chassis-type = "handset";
>> +
>> +    chosen {
>> +        #address-cells = <2>;
>> +        #size-cells = <2>;
>> +        ranges;
>> +
>> +        framebuffer0: framebuffer-front@...00000 {
>
>framebuffer@
>
>> +            compatible = "simple-framebuffer";
>> +            reg = <0 0xea600000 0 (1440 * 3200 * 4)>;
>> +
>> +            width = <1440>;
>> +            height = <3200>;
>> +            stride = <(1440 * 4)>;
>> +            format = "a8r8g8b8";
>> +        };
>> +
>> +        framebuffer1: framebuffer-rear@...9c000 {
>
>framebuffer@
>
>> +            compatible = "simple-framebuffer";
>> +            reg = <0 0xeb79c000 0 (126 * 294 * 4)>;
>> +
>> +            width = <126>;
>> +            height = <294>;
>> +            stride = <(126 * 4)>;
>> +            format = "a8r8g8b8";
>> +        };
>> +    };
>> +
>

Will fix in v2.

>
>
>> +            reg = <0 0x86100000 0 0x3900000>;
>> +            no-map;
>> +        };
>> +
>> +        pil_slpi_mem: memory@...00000 {
>> +            reg = <0 0x89a00000 0 0x2f00000>;
>> +            no-map;
>> +        };
>> +
>> +        pil_cdsp_mem: memory@...00000 {
>> +            reg = <0 0x8c900000 0 0x1e00000>;
>> +            no-map;
>> +        };
>> +
>> +        pil_ipa_fw_mem: memory@...00000 {
>> +            reg = <0 0x8e700000 0 0x10000>;
>> +            no-map;
>> +        };
>> +
>> +        pil_ipa_gsi_mem: memory@...10000 {
>> +            reg = <0 0x8e710000 0 0xa000>;
>> +            no-map;
>> +        };
>> +
>
>...
>
>> +&pm8350c_gpios {
>> +    gpio-line-names = "VDD_BOOST_5V_EN",
>> +              "NC",
>> +              "OTG_OVP_EN",
>> +              "WL_TXON",
>> +              "NC",
>> +              "NC",
>> +              "NC",
>> +              "NC",
>> +              "NC";
>> +};
>> +
>> +&pmk8350_adc_tm {
>> +    status = "okay";
>> +
>> +    pm8350-skin-therm@0 {
>
>Hm, didn't we change the node names to generic "channel" and started
>using labels? At least in next or ongoing patches? Or was it only for VADC?

I thought it was only for VADC. "channel" is not used in binding as well.