[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20230731-regie-reitschule-f540e269c348@brauner>
Date: Mon, 31 Jul 2023 14:44:35 +0200
From: Christian Brauner <brauner@...nel.org>
To: Matthew Wilcox <willy@...radead.org>
Cc: Jeff Layton <jlayton@...nel.org>,
Alexander Viro <viro@...iv.linux.org.uk>,
linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH] fs: fix request_mask variable in generic_fillattr
kerneldoc comment
On Mon, Jul 31, 2023 at 01:32:04PM +0100, Matthew Wilcox wrote:
> On Mon, Jul 31, 2023 at 02:28:49PM +0200, Christian Brauner wrote:
> > On Mon, Jul 31, 2023 at 01:18:55PM +0100, Matthew Wilcox wrote:
> > > On Mon, Jul 31, 2023 at 06:37:10AM -0400, Jeff Layton wrote:
> > > > /**
> > > > * generic_fillattr - Fill in the basic attributes from the inode struct
> > > > - * @idmap: idmap of the mount the inode was found from
> > > > - * @req_mask statx request_mask
> > > > - * @inode: Inode to use as the source
> > > > - * @stat: Where to fill in the attributes
> > > > + * @idmap: idmap of the mount the inode was found from
> > > > + * @request_mask statx request_mask
> > >
> > > Missing the colon after request_mask.
> >
> > Fixed in-tree, thanks!
>
> FWIW, a W=1 build will catch this:
>
> ../mm/filemap.c:254: warning: Function parameter or member 'folio' not described in 'filemap_remove_folio'
>
> (after having deliberately removed the colon on that line)
Thanks! I often only do W=1 builds by hand on specific files because
otherwise there's such a wall of warnings that it's hard to see what's
going on.
Powered by blists - more mailing lists