linux-kernel - Re: [PATCH] fs: fix request_mask variable in generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZMepxLLgo/Iqtj0N@casper.infradead.org>
Date:   Mon, 31 Jul 2023 13:32:04 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     Christian Brauner <brauner@...nel.org>
Cc:     Jeff Layton <jlayton@...nel.org>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH] fs: fix request_mask variable in generic_fillattr
 kerneldoc comment

On Mon, Jul 31, 2023 at 02:28:49PM +0200, Christian Brauner wrote:
> On Mon, Jul 31, 2023 at 01:18:55PM +0100, Matthew Wilcox wrote:
> > On Mon, Jul 31, 2023 at 06:37:10AM -0400, Jeff Layton wrote:
> > >  /**
> > >   * generic_fillattr - Fill in the basic attributes from the inode struct
> > > - * @idmap:	idmap of the mount the inode was found from
> > > - * @req_mask	statx request_mask
> > > - * @inode:	Inode to use as the source
> > > - * @stat:	Where to fill in the attributes
> > > + * @idmap:		idmap of the mount the inode was found from
> > > + * @request_mask	statx request_mask
> > 
> > Missing the colon after request_mask.
> 
> Fixed in-tree, thanks!

FWIW, a W=1 build will catch this:

../mm/filemap.c:254: warning: Function parameter or member 'folio' not described in 'filemap_remove_folio'

(after having deliberately removed the colon on that line)