linux-kernel - Re: [PATCH v6 1/6] soundwire: bus: Allow SoundWire peripherals to register IRQ handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 31 Jul 2023 09:03:16 +0800
From:   "Liao, Bard" <yung-chuan.liao@...ux.intel.com>
To:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Lee Jones <lee@...nel.org>,
        Charles Keepax <ckeepax@...nsource.cirrus.com>
Cc:     broonie@...nel.org, vkoul@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        linus.walleij@...aro.org, lgirdwood@...il.com,
        sanyog.r.kale@...el.com, alsa-devel@...a-project.org,
        patches@...nsource.cirrus.com, devicetree@...r.kernel.org,
        linux-gpio@...r.kernel.org, linux-spi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 1/6] soundwire: bus: Allow SoundWire peripherals to
 register IRQ handlers


On 7/29/2023 12:44 AM, Pierre-Louis Bossart wrote:
>
> On 7/28/23 17:18, Lee Jones wrote:
>> Vinod, Bard, Pierre-Louis, Sanyog,
>>
>> This has been on the list for some time now.
>>
>> Would one of you please review this, so we can get it merged?
> Sorry, I thought I provided my tag on an earlier version, but apparently
> that never reached the ML. All my earlier feedback was taken into
> account so no objections from me - just one typo below...
>
> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>


The patch looks good to me.

Acked-by: Bard Liao <yung-chuan.liao@...ux.intel.com>

>> On Tue, 25 Jul 2023, Charles Keepax wrote:
>>
>>> From: Lucas Tanure <tanureal@...nsource.cirrus.com>
>>>
>>> Currently the in-band alerts for SoundWire peripherals can only
>>> be communicated to the driver through the interrupt_callback
>>> function. This however is slightly inconvient for devices that wish to
> inconvenient
>
>>> share IRQ handling code between SoundWire and I2C/SPI, the later would
>>> normally register an IRQ handler with the IRQ subsystem. However there
>>> is no reason the SoundWire in-band IRQs can not also be communicated
>>> as an actual IRQ to the driver.