linux-kernel - Re: [PATCH] sched/topology: Covered all cpus of same node in asymmetric node setups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230731133602.GI29590@hirez.programming.kicks-ass.net>
Date:   Mon, 31 Jul 2023 15:36:02 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Bing Huang <huangbing775@....com>
Cc:     dietmar.eggemann@....com, rostedt@...dmis.org, brauner@...nel.org,
        bristot@...hat.com, bsegall@...gle.com, juri.lelli@...hat.com,
        linux-kernel@...r.kernel.org, mgorman@...e.de, mingo@...hat.com,
        vincent.guittot@...aro.org
Subject: Re: [PATCH] sched/topology: Covered all cpus of same node in
 asymmetric node setups

On Sun, Jul 30, 2023 at 06:22:03AM +0800, Bing Huang wrote:
> in asymmetric node setups, if one cpu'sd spans is empty in some depth,
> others in same node do

Sorry, what?!?

> Signed-off-by: Bing Huang <huangbing@...inos.cn>
> ---
>  kernel/sched/topology.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
> index 7cfcfe5d27b9..8c5372ad7694 100644
> --- a/kernel/sched/topology.c
> +++ b/kernel/sched/topology.c
> @@ -1045,8 +1045,10 @@ build_overlap_sched_groups(struct sched_domain *sd, int cpu)
>  		 * Domains should always include the CPU they're built on, so
>  		 * check that.
>  		 */
> -		if (!cpumask_test_cpu(i, sched_domain_span(sibling)))
> +		if (!cpumask_test_cpu(i, sched_domain_span(sibling))) {
> +			cpumask_or(covered, covered, cpumask_of_node(cpu_to_node(i)));
>  			continue;
> +		}
>  
>  		/*
>  		 * Usually we build sched_group by sibling's child sched_domain
> -- 
> 2.25.1
>