linux-kernel - Re: [PATCH] net: export dev_change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZMlAZdWX3EToTUVT@nanopsycho>
Date:   Tue, 1 Aug 2023 19:27:01 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Anvesh Jain P <quic_ajainp@...cinc.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Simon Horman <simon.horman@...igine.com>,
        Kuniyuki Iwashima <kuniyu@...zon.com>,
        Hangbin Liu <liuhangbin@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Andy Ren <andy.ren@...cruise.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Venkata Rao Kakani <quic_vkakani@...cinc.com>,
        Vagdhan Kumar <quic_vagdhank@...cinc.com>
Subject: Re: [PATCH] net: export dev_change_name function

Tue, Aug 01, 2023 at 01:21:01PM CEST, quic_ajainp@...cinc.com wrote:
>export dev_change_name function to be used by other modules.
>
>Signed-off-by: Vagdhan Kumar <quic_vagdhank@...cinc.com>
>Signed-off-by: Anvesh Jain P <quic_ajainp@...cinc.com>
>---
> net/core/dev.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/net/core/dev.c b/net/core/dev.c
>index 69a3e544676c..1dad68e2950c 100644
>--- a/net/core/dev.c
>+++ b/net/core/dev.c
>@@ -1254,6 +1254,7 @@ int dev_change_name(struct net_device *dev, const char *newname)
> 
> 	return err;
> }
>+EXPORT_SYMBOL(dev_change_name);
> 
> /**
>  *	dev_set_alias - change ifalias of a device
>
>base-commit: 0a8db05b571ad5b8d5c8774a004c0424260a90bd

nack.
1) there is no in-tree user
2) changing name from anywhere else than userspace does not make any
   sense. I'll eat my shoes if there is a sane reason for it.

Please don't send patches like this.


>-- 
>2.17.1
>