linux-kernel - Re: [PATCH] netfilter: bpf_link: avoid unused-function warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <b795ccdf-ad53-407e-ba01-a703e353b3fb@app.fastmail.com>
Date:   Tue, 01 Aug 2023 19:27:33 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Daniel Xu" <dxu@...uu.xyz>, "Arnd Bergmann" <arnd@...nel.org>
Cc:     "Pablo Neira Ayuso" <pablo@...filter.org>,
        "Jozsef Kadlecsik" <kadlec@...filter.org>,
        "Florian Westphal" <fw@...len.de>,
        "David S . Miller" <davem@...emloft.net>,
        "Eric Dumazet" <edumazet@...gle.com>,
        "Jakub Kicinski" <kuba@...nel.org>,
        "Paolo Abeni" <pabeni@...hat.com>,
        "Alexei Starovoitov" <ast@...nel.org>,
        netfilter-devel@...r.kernel.org, coreteam@...filter.org,
        Netdev <netdev@...r.kernel.org>, linux-kernel@...r.kernel.org,
        bpf@...r.kernel.org
Subject: Re: [PATCH] netfilter: bpf_link: avoid unused-function warning

On Tue, Aug 1, 2023, at 17:20, Daniel Xu wrote:
> Hi Arnd,
>
> On Tue, Aug 01, 2023 at 05:02:41PM +0200, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@...db.de>
>> 
>> The newly added function is unused in some random configurations:
>> 
>> net/netfilter/nf_bpf_link.c:32:1: error: 'get_proto_defrag_hook' defined but not used [-Werror=unused-function]
>>    32 | get_proto_defrag_hook(struct bpf_nf_link *link,
>>       | ^~~~~~~~~~~~~~~~~~~~~
>> 
>
> This was fixed in 81584c23f249 ("netfilter: bpf: Only define 
> get_proto_defrag_hook() if necessary").

Ok, I guess this will be in tomorrow's linux-next then, right?

    Arnd