[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1cbd6d5a-0e58-4a3f-b7e5-bbab09f03c5d@sirena.org.uk>
Date: Tue, 1 Aug 2023 20:05:16 +0100
From: Mark Brown <broonie@...nel.org>
To: Mike Rapoport <rppt@...nel.org>
Cc: Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will@...nel.org>,
Jonathan Corbet <corbet@....net>,
Andrew Morton <akpm@...ux-foundation.org>,
Marc Zyngier <maz@...nel.org>,
Oliver Upton <oliver.upton@...ux.dev>,
James Morse <james.morse@....com>,
Suzuki K Poulose <suzuki.poulose@....com>,
Arnd Bergmann <arnd@...db.de>, Oleg Nesterov <oleg@...hat.com>,
Eric Biederman <ebiederm@...ssion.com>,
Kees Cook <keescook@...omium.org>,
Shuah Khan <shuah@...nel.org>,
"Rick P. Edgecombe" <rick.p.edgecombe@...el.com>,
Deepak Gupta <debug@...osinc.com>,
Ard Biesheuvel <ardb@...nel.org>,
Szabolcs Nagy <Szabolcs.Nagy@....com>,
"H.J. Lu" <hjl.tools@...il.com>,
Paul Walmsley <paul.walmsley@...ive.com>,
Palmer Dabbelt <palmer@...belt.com>,
Albert Ou <aou@...s.berkeley.edu>,
linux-arm-kernel@...ts.infradead.org, linux-doc@...r.kernel.org,
kvmarm@...ts.linux.dev, linux-fsdevel@...r.kernel.org,
linux-arch@...r.kernel.org, linux-mm@...ck.org,
linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-riscv@...ts.infradead.org
Subject: Re: [PATCH v3 11/36] arm64/mm: Map pages for guarded control stack
On Tue, Aug 01, 2023 at 08:02:31PM +0300, Mike Rapoport wrote:
> On Mon, Jul 31, 2023 at 02:43:20PM +0100, Mark Brown wrote:
> > {
> > - pteval_t prot = pgprot_val(protection_map[vm_flags &
> > + pteval_t prot;
> > +
> > + /*
> > + * If this is a GCS then only interpret VM_WRITE.
> > + *
> > + * TODO: Just make protection_map[] bigger? Nothing seems
> > + * ideal here.
> > + */
> I think extending protection_map and updating adjust_protection_map() is
> cleaner and probably faster.
That was my initial thought but then I immediately started second
guessing myself about review comments. Hopefully Will or Catalin will
weigh in.
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists