[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230801211139.GA51676@bhelgaas>
Date: Tue, 1 Aug 2023 16:11:39 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Shuah Khan <skhan@...uxfoundation.org>,
David Gow <davidgow@...gle.com>,
Daniel Latypov <dlatypov@...gle.com>,
"Steven Rostedt (Google)" <rostedt@...dmis.org>,
Bjorn Helgaas <bhelgaas@...gle.com>,
linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
kunit-dev@...glegroups.com, linux-arm-kernel@...ts.infradead.org,
linux-pci@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
"H. Peter Anvin" <hpa@...or.com>,
Brendan Higgins <brendan.higgins@...ux.dev>,
Mark Rutland <mark.rutland@....com>,
Lorenzo Pieralisi <lpieralisi@...nel.org>,
Sudeep Holla <sudeep.holla@....com>,
Masami Hiramatsu <mhiramat@...nel.org>,
Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v4 1/4] kernel.h: Split out COUNT_ARGS() and
CONCATENATE() to args.h
On Wed, Jul 19, 2023 at 12:11:44AM +0300, Andy Shevchenko wrote:
> kernel.h is being used as a dump for all kinds of stuff for a long time.
> The COUNT_ARGS() and CONCATENATE() macros may be used in some places
> without need of the full kernel.h dependency train with it.
>
> Here is the attempt on cleaning it up by splitting out these macros().
>
> While at it, include new header where it's being used.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Acked-by: Steven Rostedt (Google) <rostedt@...dmis.org>
Acked-by: Bjorn Helgaas <bhelgaas@...gle.com> # PCI
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index 0ff7500772e6..eeb2e6f6130f 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -23,7 +23,7 @@
> #ifndef LINUX_PCI_H
> #define LINUX_PCI_H
>
> -
> +#include <linux/args.h>
> #include <linux/mod_devicetable.h>
>
> #include <linux/types.h>
If there's not a reason otherwise, I'd put this in the main list
instead of the weirdly separated mod_devicetable.h.
Powered by blists - more mailing lists