linux-kernel - Re: [PATCH v4 1/4] kernel.h: Split out COUNT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 2 Aug 2023 06:18:33 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     Shuah Khan <skhan@...uxfoundation.org>,
        David Gow <davidgow@...gle.com>,
        Daniel Latypov <dlatypov@...gle.com>,
        "Steven Rostedt (Google)" <rostedt@...dmis.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
        kunit-dev@...glegroups.com, linux-arm-kernel@...ts.infradead.org,
        linux-pci@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
        "H. Peter Anvin" <hpa@...or.com>,
        Brendan Higgins <brendan.higgins@...ux.dev>,
        Mark Rutland <mark.rutland@....com>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Sudeep Holla <sudeep.holla@....com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v4 1/4] kernel.h: Split out COUNT_ARGS() and
 CONCATENATE() to args.h

On Tue, Aug 01, 2023 at 04:11:39PM -0500, Bjorn Helgaas wrote:
> On Wed, Jul 19, 2023 at 12:11:44AM +0300, Andy Shevchenko wrote:
> > kernel.h is being used as a dump for all kinds of stuff for a long time.
> > The COUNT_ARGS() and CONCATENATE() macros may be used in some places
> > without need of the full kernel.h dependency train with it.
> > 
> > Here is the attempt on cleaning it up by splitting out these macros().
> > 
> > While at it, include new header where it's being used.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > Acked-by: Steven Rostedt (Google) <rostedt@...dmis.org>
> 
> Acked-by: Bjorn Helgaas <bhelgaas@...gle.com>	# PCI

Thank you!

...

> > -
> > +#include <linux/args.h>
> >  #include <linux/mod_devicetable.h>
> >  
> >  #include <linux/types.h>
> 
> If there's not a reason otherwise, I'd put this in the main list
> instead of the weirdly separated mod_devicetable.h.

The idea is to make them alphabetically ordered. currently even main list
is a mess. And I have no idea why mod_devicetable.h is so special, a few
bus headers (e.g., i2c, spi) consider that just as yet another header while
actually ain't using it (in the respective _headers_).

That said, I would take the sorting change as a separate one that can be
done after this.

-- 
With Best Regards,
Andy Shevchenko