linux-kernel - Re: [PATCH] virtio: Remove PM #ifdef guards to fix i2c driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c809220b8f10c6c9a3d05bbbd416fbb27d654d2d.camel@crapouillou.net>
Date:   Wed, 02 Aug 2023 01:06:47 +0200
From:   Paul Cercueil <paul@...pouillou.net>
To:     Arnd Bergmann <arnd@...nel.org>, Andi Shyti <andi.shyti@...nel.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
        Stefano Garzarella <sgarzare@...hat.com>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Feng Liu <feliu@...dia.com>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] virtio: Remove PM #ifdef guards to fix i2c driver

Hi,

Le mardi 01 août 2023 à 12:58 +0200, Arnd Bergmann a écrit :
> From: Arnd Bergmann <arnd@...db.de>
> 
> A cleanup in the virtio i2c caused a build failure:
> 
> drivers/i2c/busses/i2c-virtio.c:270:10: error: 'struct virtio_driver'
> has no member named 'freeze'
> drivers/i2c/busses/i2c-virtio.c:271:10: error: 'struct virtio_driver'
> has no member named 'restore'
> 
> Change the structure definition to allow this cleanup to
> be applied everywhere.
> 
> Fixes: 73d546c76235b ("i2c: virtio: Remove #ifdef guards for PM
> related functions")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thanks, I didn't realize it was merged already.

Reviewed-by: Paul Cercueil <paul@...pouillou.net>

Cheers,
-Paul

> ---
>  include/linux/virtio.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/linux/virtio.h b/include/linux/virtio.h
> index 0f3b9017dff40..9b94e2c9bbb81 100644
> --- a/include/linux/virtio.h
> +++ b/include/linux/virtio.h
> @@ -218,10 +218,8 @@ struct virtio_driver {
>         void (*scan)(struct virtio_device *dev);
>         void (*remove)(struct virtio_device *dev);
>         void (*config_changed)(struct virtio_device *dev);
> -#ifdef CONFIG_PM
>         int (*freeze)(struct virtio_device *dev);
>         int (*restore)(struct virtio_device *dev);
> -#endif
>  };
>  
>  static inline struct virtio_driver *drv_to_virtio(struct
> device_driver *drv)