linux-kernel - Re: [PATCH] virtio: Remove PM #ifdef guards to fix i2c driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230801234224.e33sikkjug276ktt@intel.intel>
Date:   Wed, 2 Aug 2023 01:42:24 +0200
From:   Andi Shyti <andi.shyti@...nel.org>
To:     Paul Cercueil <paul@...pouillou.net>
Cc:     Arnd Bergmann <arnd@...nel.org>, Arnd Bergmann <arnd@...db.de>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
        Stefano Garzarella <sgarzare@...hat.com>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Feng Liu <feliu@...dia.com>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org, Wolfram Sang <wsa@...nel.org>
Subject: Re: [PATCH] virtio: Remove PM #ifdef guards to fix i2c driver

Hi,

On Wed, Aug 02, 2023 at 01:06:47AM +0200, Paul Cercueil wrote:
> Hi,
> 
> Le mardi 01 août 2023 à 12:58 +0200, Arnd Bergmann a écrit :
> > From: Arnd Bergmann <arnd@...db.de>
> > 
> > A cleanup in the virtio i2c caused a build failure:
> > 
> > drivers/i2c/busses/i2c-virtio.c:270:10: error: 'struct virtio_driver'
> > has no member named 'freeze'
> > drivers/i2c/busses/i2c-virtio.c:271:10: error: 'struct virtio_driver'
> > has no member named 'restore'
> > 
> > Change the structure definition to allow this cleanup to
> > be applied everywhere.
> > 
> > Fixes: 73d546c76235b ("i2c: virtio: Remove #ifdef guards for PM
> > related functions")
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> 
> Thanks, I didn't realize it was merged already.
> 
> Reviewed-by: Paul Cercueil <paul@...pouillou.net>

Actually this fix is taken from linux-next, it's not in
Wolfram's branch, it's in mine. I can still force-push a fixed
version in Paul's original patch in order to avoid breaking the
bisectability.

Andi